Closed Bug 1060765 Opened 10 years ago Closed 9 years ago

Add a test for the log parser error line regex

Categories

(Tree Management :: Treeherder: Data Ingestion, defect, P4)

Product:
Tree Management
Component:
Treeherder: Data Ingestion
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

Details

Attachments

(1 file)

Add tests for the log parser error line regex
(deleted), text/x-github-pull-request
camd
: review+
Details
In bug 1040418, several issues were found with the log parser regex (eg regex terms being listed in the substring list, rather than the regex list), which meant failures were not matched in logs correctly. We should add tests to cover all of these: https://github.com/mozilla/treeherder-service/blob/master/treeherder/log_parser/parsers.pyx#L273
Summary: Add a test for the log parser log error line regex → Add a test for the log parser error line regex
Priority: P4 → P3
Blocks: 1072681
No longer blocks: 1072681
Component: Treeherder → Treeherder: Data Ingestion
Priority: P3 → P4
Assignee: nobody → emorley
Status: NEW → ASSIGNED
Attachment #8646265 - Flags: review?(cdawson)
Attachment #8646265 - Flags: review?(cdawson) → review+
Commits pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/27c024d22b3a5ccae75d6d13a4a5bf1234cd377d Bug 1060765 - Move the error summary tests to tests/model/ Since the code they are testing was moved to the models directory, as part of bug 1163182. https://github.com/mozilla/treeherder/commit/33b1d448566e23b5f2ce6150c507aa44bc02f440 Bug 1060765 - Refactor the error parser to make it easier to unit test https://github.com/mozilla/treeherder/commit/e22853f090c3184c92a820f7df7fedaf8037b9ca Bug 1060765 - Add tests for the log parser error line regex
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: