Closed
Bug 1063643
Opened 10 years ago
Closed 10 years ago
Allow for building with a limited set of resources
Categories
(Firefox Build System :: Android Studio and Gradle Integration, defect)
Firefox Build System
Android Studio and Gradle Integration
All
Android
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla35
People
(Reporter: rnewman, Assigned: rnewman)
References
Details
Attachments
(1 file)
(deleted),
patch
|
nalexander
:
review+
|
Details | Diff | Splinter Review |
Above and beyond Bug 1063109, we'd also like to eliminate xxhdpi and friends, as well as tablet, from a resource-constrained build.
This might simply be down to passing `--preferred-configurations hdpi` to aapt, but we'll see about locale selection.
Assignee | ||
Comment 1•10 years ago
|
||
Awww yeaaaahhhh.
0:22.23 Applying preferred filter: hdpi
0:22.23 Pruning unneeded resource: /Users/rnewman/moz/android/android-sdk-macosx/extras/google/google_play_services/libproject/google-play-services_lib/res/drawable-mdpi/common_signin_btn_icon_disabled_dark.9.png
0:22.23 Pruning unneeded resource: /Users/rnewman/moz/android/android-sdk-macosx/extras/google/google_play_services/libproject/google-play-services_lib/res/drawable-xxhdpi/common_signin_btn_icon_disabled_dark.9.png
0:22.23 Pruning unneeded resource: /Users/rnewman/moz/android/android-sdk-macosx/extras/google/google_play_services/libproject/google-play-services_lib/res/drawable-mdpi/common_signin_btn_icon_disabled_focus_dark.9.png
0:22.23 Pruning unneeded resource: /Users/rnewman/moz/android/android-sdk-macosx/extras/google/google_play_services/libproject/google-play-services_lib/res/drawable-xxhdpi/common_signin_btn_icon_disabled_focus_dark.9.png
0:22.23 Pruning unneeded resource: /Users/rnewman/moz/android/android-sdk-macosx/extras/google/google_play_services/libproject/google-play-services_lib/res/drawable-mdpi/common_signin_btn_icon_disabled_focus_light.9.png
Assignee | ||
Comment 2•10 years ago
|
||
This builds, but I haven't verified that the build runs.
Attachment #8485332 -
Flags: review?(nalexander)
Comment 3•10 years ago
|
||
Comment on attachment 8485332 [details] [diff] [review]
Allow for building Fennec with a limited set of resources. v1
Review of attachment 8485332 [details] [diff] [review]:
-----------------------------------------------------------------
I have no problem with this, but I'd like to see a try build before landing.
::: build/autoconf/android.m4
@@ +412,5 @@
> fi
> ;;
> esac
>
> +MOZ_ARG_ENABLE_BOOL(android-resource-constrained,
Huh, you learn something every day.
Attachment #8485332 -
Flags: review?(nalexander) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Assignee | ||
Comment 5•10 years ago
|
||
Comment 6•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Updated•5 years ago
|
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 35 → mozilla35
You need to log in
before you can comment on or make changes to this bug.
Description
•