This change alone cuts our APK size by 2.75MB.

Comment on attachment 8485337 [details] [diff] [review] Exclude fonts from constrained APKs. v1 I wouldn't mind being more specific with the flag here. We might also use this code for packaging GeckoView too. Maybe change: MOZ_ANDROID_RESOURCE_CONSTRAINED to: MOZ_ANDROID_BUNDLE_FONTS And then also set MOZ_ANDROID_BUNDLE_FONTS when building a resource constrained APK.

Comment on attachment 8485337 [details] [diff] [review] Exclude fonts from constrained APKs. v1 Review of attachment 8485337 [details] [diff] [review]: ----------------------------------------------------------------- Sorry this lagged; I thought I cleared it but it was in a background tab. I agree with mfinkle: consider a fine-grained fonts guard that is set by the coarser resource constrained guard. I'm not too concerned either way. Soon, we should talk strategy on getting either multiple build jobs for the different resource sets, or multi-output build jobs.

(In reply to Nick Alexander :nalexander from comment #4) > I agree with mfinkle: consider a fine-grained fonts guard that is set by the > coarser resource constrained guard. I'm not too concerned either way. Did do so. The important stanza is: +MOZ_ARG_DISABLE_BOOL(android-include-fonts, +[ --disable-android-include-fonts + disable the inclusion of fonts into the final APK], + MOZ_ANDROID_EXCLUDE_FONTS=1) + +if test -n "$MOZ_ANDROID_EXCLUDE_FONTS"; then + AC_DEFINE(MOZ_ANDROID_EXCLUDE_FONTS, $MOZ_ANDROID_EXCLUDE_FONTS) + AC_SUBST(MOZ_ANDROID_EXCLUDE_FONTS) +fi +