Closed Bug 1066989 Opened 10 years ago Closed 10 years ago

Correct Thunderbird treestatus and clobberer repo name handling after bug 1035222

Categories

(Tree Management :: Treeherder, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

References

Details

Attachments

(1 file)

Bug 1035220 adjusted the treestatus/clobberer repo name handling in the UI for various thunderbird repos, since the service doesn't provide the URLs (it probably should; lets do that in another bug) and so the UI has to derive them - however the thunderbird repos are slightly inconsistent with the others. Unfortunately the munging added there was based on a repo name of form "thunderbird-trunk", when that repo name was in fact incorrect, since it doesn't match any of the data sources handled in the service. Bug 1035222 will fix the repo name in the service, so this bug will now make the UI derive the clobberer and treestatus URLs from this new name. We'll want to keep the getTreeStatusName fix from bug 1035220 since that's needed either way :-)
Attachment #8489014 - Flags: review?(mdoglio)
Commits pushed to master at https://github.com/mozilla/treeherder-ui https://github.com/mozilla/treeherder-ui/commit/166a20a728a5793afdbb3503e6802647f200be26 Bug 1066989 - Fix the treestatus and clobberer URLs for Thunderbird Now that bug 1035222 has corrected the base repo name, the clobberer workaround added by bug 1035220 must be removed - and the treestatus name generation tweaked. https://github.com/mozilla/treeherder-ui/commit/84e35a01d7487ac59903ca1427acb885a78d7e7a Merge pull request #179 from mozilla/fix-thunderbird-urls Bug 1066989 - Fix the treestatus and clobberer URLs for Thunderbird
Attachment #8489014 - Flags: review?(mdoglio) → review+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Commits pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/a4810177db7ba4bcef0b24f2b18b1ffa8474c6fa Bug 1066989 - Fix the treestatus and clobberer URLs for Thunderbird Now that bug 1035222 has corrected the base repo name, the clobberer workaround added by bug 1035220 must be removed - and the treestatus name generation tweaked. https://github.com/mozilla/treeherder/commit/fca05d2d2b9e79bb9b69900d3d8b7b139fb7b844 Merge pull request #179 from mozilla/fix-thunderbird-urls Bug 1066989 - Fix the treestatus and clobberer URLs for Thunderbird
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: