Closed
Bug 1067485
Opened 10 years ago
Closed 10 years ago
Forward/back browser controls do not adjust filters
Categories
(Tree Management :: Treeherder, defect, P3)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Unassigned)
References
Details
(Keywords: regression)
In TBPL, and also for Treeherder for certain param changes, it's possible to go back to previous parameters by using the browser back button (or in my case, the back button on my mouse).
eg:
1) Open http://treeherder-dev.allizom.org/ui/#/jobs?repo=addon-sdk
2) Press the 'u' key to enter only unstarred mode.
3) Press the browser back button
-> You go back to the view seen before the 'u' key was pressed.
This works ok in treeherder for the above, however does not work for this:
1) Open http://treeherder-dev.allizom.org/ui/#/jobs?repo=addon-sdk
2) Select a job
3) Click the buildername for the job in the job details panel (which causes a filter to be applied with the current job name)
4) Press the browser back button
Expected:
Filter applied in step #3 is removed, since the history API change causes the UI to update.
Actual:
Nothing happens.
Reporter | ||
Updated•10 years ago
|
Priority: P2 → P1
Reporter | ||
Comment 1•10 years ago
|
||
(Reducing the number of P1 bugs at any one time, so there are a half dozen or so top issues on which efforts can be focused)
Priority: P1 → P2
Reporter | ||
Updated•10 years ago
|
No longer blocks: treeherder-dev-transition
Keywords: regression
Reporter | ||
Updated•10 years ago
|
Priority: P2 → P3
Comment 2•10 years ago
|
||
I just tried this and it seems to be working now for me, I think(?). The filter is removed when I click the back button.
Flags: needinfo?(emorley)
Updated•10 years ago
|
Flags: needinfo?(emorley)
Comment 3•10 years ago
|
||
Yeah, this got fixed at some point.
Comment 4•10 years ago
|
||
Cool, marking fixed per above, minus an assignee.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•