Closed Bug 1068732 Opened 10 years ago Closed 10 years ago

Mozlog's status handler needs to know about crashes

Categories

(Testing :: Mozbase, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla35

People

(Reporter: chmanchester, Assigned: chmanchester)

References

Details

Attachments

(1 file, 2 obsolete files)

A "crash" action from mozlog should to be more than enough to fail a job.
Assignee: nobody → cmanchester
Status: NEW → ASSIGNED
(In reply to Chris Manchester [:chmanchester] from comment #1) > Created attachment 8490833 [details] [diff] [review] > Add action counts to mozlog status handler to account for crashes. I think this is what we want here. This will let individual harnesses decide whether to include test_status in final counts and avoids introducing a new set of well known strings that represent statuses. I don't think the mozharness consumer will get significantly more complicated as a result, but let's see.
This gets rid of special strings just for mozlog. I think the failure conditions based on the summary are pretty straightforward. Down the road just a little bit we might want moztest to have an idea of results processing that replaces that in mozharness altogether. Here it is on ash turning marionette desktop orange with the patch from bug 1066785: https://tbpl.mozilla.org/?tree=Ash&rev=3893ea460be3
Attachment #8492241 - Flags: review?(james)
Attachment #8490833 - Attachment is obsolete: true
Comment on attachment 8492241 [details] [diff] [review] Add action counts to mozlog status handler to account for crashes. Review of attachment 8492241 [details] [diff] [review]: ----------------------------------------------------------------- ::: testing/mozbase/mozlog/mozlog/structured/handlers/statushandler.py @@ +10,4 @@ > from mozlog.structured.structuredlog import log_levels > > +RunSummary = namedtuple("RunSummary", > + ("unexpected", "skipped", "level_counts", "action_counts")) Call level_counts log_level_counts.
Attachment #8492241 - Flags: review?(james) → review+
Attachment #8492241 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: