We need to update the directory passed to printbuildrev.py from ./<appName>.app/Contents/MacOS to ./<appName>.app/Contents/Resources. I'm not sure where this is set. Ben, would you know? See: https://tbpl.mozilla.org/php/getParsedLog.php?id=48405633&tree=Oak&full=1#error0 Please ignore the other failures that aren't related to printbuildrev.py as those were already occurring before the v2 signatures.

This is set in one of our Buildbot factories: https://github.com/mozilla/build-buildbotcustom/blob/master/process/factory.py#L4683 The property (exepath) is shared both cross-branch and for other functions (like actually launching the browser), so this is going to be tricky to deal with. We might be able to pass just "foo.app" to printbuildrev.py for Mac, and then have the script walk the tree to find the ini file...

Dave, I was told that you're in the process of replacing these tests with mochitest-based ones. The old ones are hidden everywhere anyways - should we bother fixing this?

(In reply to Ben Hearsum [:bhearsum] from comment #2) > Dave, I was told that you're in the process of replacing these tests with > mochitest-based ones. The old ones are hidden everywhere anyways - should we > bother fixing this? I'm not really sure how this affects the jetpack tests, perhaps you could elaborate? How soon would this totally hose the tests and how much work is it to fix? I'm trying to get the mochitest versions up and running but so far I'm finding it hard to get reviews on the patches so it's slow going.

Here is a run on Oak where JP tests failed on OSX: https://tbpl.mozilla.org/?tree=Oak&rev=6f35795603f7 More specifically, it's the two OSX runs here: https://tbpl.mozilla.org/php/getParsedLog.php?id=48405633&tree=Oak&full=1 https://tbpl.mozilla.org/php/getParsedLog.php?id=48406724&tree=Oak&full=1 These failures occurred due to the changes we had to make to support v2 signatures on OSX (see bug 1047584 and dependents). Some of the patches are still under review and we need to run tests on Oak before we can land on m-c, but the goal is to land this as soon as possible.

So I don't know what printbuildrev.py is or why it is run as part of the jetpack tests.

(In reply to Dave Townsend [:mossop] from comment #3) > (In reply to Ben Hearsum [:bhearsum] from comment #2) > > Dave, I was told that you're in the process of replacing these tests with > > mochitest-based ones. The old ones are hidden everywhere anyways - should we > > bother fixing this? > > I'm not really sure how this affects the jetpack tests, perhaps you could > elaborate? > > How soon would this totally hose the tests and how much work is it to fix? > I'm trying to get the mochitest versions up and running but so far I'm > finding it hard to get reviews on the patches so it's slow going. It's probably more than a day of work to fix them, but if the current Jetpacks tests are deprecated and being ignored (which _seems_ like it's the case, given that they're hidden), I don't think it's worth doing.

Unless I hear otherwise I'm going to work on the assumption that these aren't useful enough to fix, given that they're being replaced in the near future. Please re-open if that's wrong.