Closed
Bug 106993
Opened 23 years ago
Closed 23 years ago
Spurious corruption error if default platform is not available
Categories
(Bugzilla :: Creating/Changing Bugs, defect, P1)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.16
People
(Reporter: mozilla-work, Assigned: bbaetz)
References
Details
Attachments
(1 file)
(deleted),
patch
|
justdave
:
review-
|
Details | Diff | Splinter Review |
I have modified the available platforms by removing all the platforms that we
don't support. Now if someone logs in from Linux they get the following error:
Error Message
=============
Possible bug database corruption has been detected. Please send mail to
stephen@tgivan.com with details of what you were doing
when this message appeared. Thank you.
src = All Windows 3.1 Windows 95 Windows 98 Windows 2000 Windows NT
Solaris SunOS other
default = Linux
Reporter | ||
Comment 1•23 years ago
|
||
Reporter | ||
Comment 2•23 years ago
|
||
The attached file fixes make_popup by changing the default to "" if the default
doesn't exist in the src list. The patch was generated from my modified version
of 2.4. It shouldn't be much different.
Reporter | ||
Comment 3•23 years ago
|
||
s/2.4/2.14/
Assignee | ||
Comment 4•23 years ago
|
||
Doesn't this negate the error checking on other uses of make_popup? Wouldn't it
be better to make this adjustment in enter_bug.cgi, where we know that doing so
is correct, rather than affect an arbitary number of users, for which triggering
this error does indicate corruption of some sort?
Comment 5•23 years ago
|
||
Comment on attachment 55278 [details] [diff] [review]
Fix
I agree with Brad, changing it in CGI.pl is a Bad Thing.
Need to fix enter_bug.cgi instead.
Attachment #55278 -
Flags: review-
Updated•23 years ago
|
Priority: -- → P1
Target Milestone: --- → Bugzilla 2.16
Comment 6•23 years ago
|
||
Don't fix it until the templatisation gets checked in, or you'll probably have
to fix it again :-)
Gerv
Depends on: 103953
Assignee | ||
Comment 7•23 years ago
|
||
This blocks strict value checks, which affects data integrety checks, so I'd
like to get it done sooner rather than later.
gerv: I can come up with a patch easily enough. When is your enter_bug stuff
being checked in? I'll go look at that patch now, I guess.
Comment 8•23 years ago
|
||
bbaetz: feel free to fix this now :-)
Gerv
Assignee | ||
Comment 9•23 years ago
|
||
This got fixed as a side effect of how gerv reworked the template, so makepopup
is no longer being used. If the patform isn't in the list, then none of them
will be the default, so the first one in the list will be selected (which is All)
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 10•23 years ago
|
||
*** Bug 57822 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 11•23 years ago
|
||
*** Bug 137394 has been marked as a duplicate of this bug. ***
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•