Closed
Bug 119715
Opened 23 years ago
Closed 23 years ago
strictvaluechecks should always be enabled
Categories
(Bugzilla :: Creating/Changing Bugs, defect, P2)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.16
People
(Reporter: bbaetz, Assigned: bbaetz)
References
Details
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
justdave
:
review+
gerv
:
review+
|
Details | Diff | Splinter Review |
test upload for bbaetz
ISTR a discussion last year mentioning that these were only a param because they
hadn't been tested when added. Since bmo runs with these on (and I have one more
check we need to add), I think this param is safe to remove.
|
||
Comment 1•23 years ago
|
||
someone can obsolete this at their first chance, I'm just testing attachments
for bbaetz.
|
Assignee | |
Comment 2•23 years ago
|
||
Attachment #64708 -
Attachment is obsolete: true
|
|
||
Comment 3•23 years ago
|
||
Comment on attachment 64709 [details] [diff] [review]
patch
r= justdave
visual inspection looks good. The code passes the tests. 2nd reviewer should
test it live though.
Attachment #64709 -
Flags: review+
|
||
Updated•23 years ago
|
Priority: -- → P2
Target Milestone: --- → Bugzilla 2.18
|
|
Assignee | |
Comment 4•23 years ago
|
||
I'd forgotten about those other bugs.
In any event, moving back to 2.16 because I have a trivial patch, and it does
prevent corruption, which isn't detected by sanitychecking (if the enum is given
an invalid value, it displays as '', but testing for == '' doesn't match)
Status: NEW → ASSIGNED
Target Milestone: Bugzilla 2.18 → Bugzilla 2.16
|
|
Assignee | |
Comment 5•23 years ago
|
||
mattyt pointed out that there was a comment referring to strict value checks
which I didn't remove.
Attachment #64709 -
Attachment is obsolete: true
|
|
||
Comment 6•23 years ago
|
||
Comment on attachment 65334 [details] [diff] [review]
new patch
r= justdave
Attachment #65334 -
Flags: review+
|
||
Comment 7•23 years ago
|
||
Comment on attachment 65334 [details] [diff] [review]
new patch
r=gerv.
Gerv
Attachment #65334 -
Flags: review+
|
|
||
Comment 8•23 years ago
|
||
Bradley - you can check this in, you know :-)
Gerv
|
|
Assignee | |
Comment 9•23 years ago
|
||
Nope, I need bug 106993 in first.
|
|
Assignee | |
Comment 10•23 years ago
|
||
but gerv fixed that bug on the side, so checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
|
||
Comment 11•20 years ago
|
||
*** Bug 226748 has been marked as a duplicate of this bug. ***
|
||
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•