Closed
Bug 1070843
Opened 10 years ago
Closed 10 years ago
[Text Selection] Selection bubble is shown when launch message app
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: pchang, Assigned: gduan)
References
Details
Attachments
(1 file)
* Description:
Selection bubble is shown when launch message app at first time
* Reproduction steps:
a. Save draft messages in message app
b. Kill message app and launch it again
c. Select the draft message
* Expected result:
Selection bubble is not shown.
* Actual result:
Selection bubble is shown.
[Logs]
This is the selection log I found when this problem happened.
E/GeckoConsole(13843): Content JS LOG: [Dump: TextSelectionDialog]"{\"rect\":{\"width\":320,\"height\":539.3333129882812,\"top\":30,\"bottom\":569.3333129882812,\"left\":0,\"right\":320},\"commands\":{\"canSelectAll\":true,\"canCut\":false,\"canCopy\":true,\"canPaste\":false},\"zoomFactor\":1,\"reasons\":[\"drag\",\"mousedown\"],\"isCollapsed\":true,\"msg_name\":\"selectionchange\",\"offsetX\":0,\"offsetY\":0}"
E/GeckoConsole(13843): Content JS LOG: [Dump: TextSelectionDialog]"{\"rect\":{\"width\":320,\"height\":539.3333129882812,\"top\":30,\"bottom\":569.3333129882812,\"left\":0,\"right\":320},\"commands\":{\"canSelectAll\":true,\"canCut\":false,\"canCopy\":true,\"canPaste\":false},\"zoomFactor\":1,\"reasons\":[],\"isCollapsed\":true,\"msg_name\":\"selectionchange\",\"offsetX\":0,\"offsetY\":0}"
E/GeckoConsole(13843): Content JS LOG: [Dump: TextSelectionDialog]"{\"rect\":{\"width\":0,\"height\":0,\"top\":0,\"bottom\":0,\"left\":0,\"right\":0},\"commands\":{\"canSelectAll\":true,\"canCut\":false,\"canCopy\":false,\"canPaste\":false},\"zoomFactor\":1,\"reasons\":[],\"isCollapsed\":true,\"msg_name\":\"selectionchange\",\"offsetX\":0,\"offsetY\":30}"
E/GeckoConsole(13843): Content JS LOG: [Dump: TextSelectionDialog]"{\"rect\":{\"width\":0,\"height\":0,\"top\":0,\"bottom\":0,\"left\":0,\"right\":0},\"commands\":{\"canSelectAll\":true,\"canCut\":false,\"canCopy\":false,\"canPaste\":false},\"zoomFactor\":1,\"reasons\":[],\"isCollapsed\":true,\"msg_name\":\"selectionchange\",\"offsetX\":0,\"offsetY\":30}"
E/GeckoConsole(13843): Content JS LOG: [Dump: TextSelectionDialog]"{\"rect\":{\"width\":0,\"height\":0,\"top\":0,\"bottom\":0,\"left\":0,\"right\":0},\"commands\":{\"canSelectAll\":true,\"canCut\":false,\"canCopy\":false,\"canPaste\":false},\"zoomFactor\":1,\"reasons\":[\"selectall\"],\"isCollapsed\":true,\"msg_name\":\"selectionchange\",\"offsetX\":0,\"offsetY\":30}"
E/GeckoConsole(13843): Content JS LOG: [Dump: TextSelectionDialog]"{\"rect\":{\"width\":78.01666259765625,\"height\":231,\"top\":298.33331298828125,\"bottom\":529.3333129882812,\"left\":45,\"right\":123.01666259765625},\"commands\":{\"canSelectAll\":true,\"canCut\":true,\"canCopy\":true,\"canPaste\":false},\"zoomFactor\":1,\"reasons\":[\"selectall\"],\"isCollapsed\":false,\"msg_name\":\"selectionchange\",\"offsetX\":0,\"offsetY\":30}"
E/GeckoConsole(13843): Content JS LOG: [Dump: TextSelectionDialog]"{\"rect\":{\"width\":78.01666259765625,\"height\":231,\"top\":298.33331298828125,\"bottom\":529.3333129882812,\"left\":45,\"right\":123.01666259765625},\"commands\":{\"canSelectAll\":true,\"canCut\":true,\"canCopy\":true,\"canPaste\":false},\"zoomFactor\":1,\"reasons\":[\"selectall\"],\"isCollapsed\":false,\"msg_name\":\"selectionchange\",\"offsetX\":0,\"offsetY\":30}"
E/GeckoConsole(13843): Content JS LOG: [Dump: TextSelectionDialog]"{\"rect\":{\"width\":0,\"height\":0,\"top\":0,\"bottom\":0,\"left\":0,\"right\":0},\"commands\":{\"canSelectAll\":true,\"canCut\":false,\"canCopy\":false,\"canPaste\":false},\"zoomFactor\":1,\"reasons\":[\"collapsetoend\"],\"isCollapsed\":true,\"msg_name\":\"selectionchange\",\"offsetX\":0,\"offsetY\":30}"
Reporter | ||
Updated•10 years ago
|
Blocks: CopyPasteLegacy
Reporter | ||
Comment 1•10 years ago
|
||
When I first time launch the message app, gecko received the selectAllChildren from JS side.
I guess this is the root cause why the selection bubble is shown.
Reporter | ||
Comment 2•10 years ago
|
||
(In reply to peter chang[:pchang][:peter] from comment #1)
> When I first time launch the message app, gecko received the
> selectAllChildren from JS side.
> I guess this is the root cause why the selection bubble is shown.
The following is the call of selectAll triggered from sms app.
Therefore, the selection bubble is also needed to handle collapse end event.
Reporter | ||
Comment 3•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → gduan
Assignee | ||
Comment 4•10 years ago
|
||
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8493484 [details]
PR to master
Hi Peter,
could I have your feedback on this patch?
Attachment #8493484 -
Flags: feedback?(pchang)
Reporter | ||
Comment 6•10 years ago
|
||
Comment on attachment 8493484 [details]
PR to master
LGTM
Attachment #8493484 -
Flags: feedback?(pchang) → feedback+
Assignee | ||
Comment 7•10 years ago
|
||
Comment on attachment 8493484 [details]
PR to master
Hi Alive,
could you review this patch?
text_seleciton bubble should hide itself when get collapsetoend.
Attachment #8493484 -
Flags: review?(alive)
Updated•10 years ago
|
Attachment #8493484 -
Flags: review?(alive) → review+
Assignee | ||
Comment 8•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•