Closed
Bug 1070863
Opened 10 years ago
Closed 10 years ago
The preprocessed channel-prefs.js file needs to be the same for each build
Categories
(Firefox :: Installer, defect)
Tracking
()
RESOLVED
FIXED
Firefox 35
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
We don't update the channel-prefs.js file on app update though we do add it if it doesn't exist.
When it is preprocessed build specific info is left in the file such as the first line below:
//@line 2 "c:\builds\moz2_slave\m-cen-w32-ntly-000000000000000\build\browser\app\profile\channel-prefs.js"
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
pref("app.update.channel", "nightly");
This will break Mac v2 signing so it can't be present.
|
Assignee | |
Comment 1•10 years ago
|
||
Probably more appropriate as a toolkit bug since that is where it is preprocessed.
|
|
Assignee | |
Comment 2•10 years ago
|
||
Assignee: nobody → robert.strong.bugs
Status: NEW → ASSIGNED
Attachment #8493215 -
Flags: review?(ted)
|
|
Assignee | |
Comment 3•10 years ago
|
||
Pushed to oak
https://hg.mozilla.org/projects/oak/rev/ee69b981715c
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8493215 [details] [diff] [review]
patch rev1
Review of attachment 8493215 [details] [diff] [review]:
-----------------------------------------------------------------
Bleh.
Attachment #8493215 -
Flags: review?(ted) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
Pushed to fx-team
https://hg.mozilla.org/integration/fx-team/rev/2cc605ebaad8
|
||
Comment 6•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
|
|
Assignee | |
Comment 7•10 years ago
|
||
Landed on aurora in the Mac V2 signing combined patch in bug 1047584
status-firefox34:
--- → fixed
status-firefox35:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•