Closed
Bug 1074011
Opened 10 years ago
Closed 10 years ago
Thunderbird's preprocessed channel-prefs.js file needs to be the same for each build
Categories
(Thunderbird :: Installer, defect)
Tracking
(thunderbird34 fixed, thunderbird35 fixed, thunderbird36 fixed)
RESOLVED
FIXED
Thunderbird 36.0
People
(Reporter: robert.strong.bugs, Assigned: jsbruner)
References
Details
Attachments
(1 file)
(deleted),
patch
|
standard8
:
review+
standard8
:
approval-comm-aurora+
standard8
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
Port of bug 1070863
Reporter | ||
Comment 1•10 years ago
|
||
Reporter | ||
Comment 2•10 years ago
|
||
I won't be able to drive this patch into the tree
Assignee | ||
Comment 4•10 years ago
|
||
I should be able to, yes. Assigning to myself so I don't forget.
Assignee: nobody → josiah
Flags: needinfo?(josiah)
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8496634 [details] [diff] [review]
patch
Review of attachment 8496634 [details] [diff] [review]:
-----------------------------------------------------------------
This looks fine to me, but I don't really know what the GARBAGE stuff does, and that part isn't part of the Fx or SM patch, so I don't feel confident reviewing this.
So I'm going to let Standard8 review it.
Attachment #8496634 -
Flags: review?(standard8)
Comment 6•10 years ago
|
||
Comment on attachment 8496634 [details] [diff] [review]
patch
Ok, looks good. I'm pretty sure this is needed on aurora & beta, so a=me for landing on those. Please flag any other patches that we need as well.
Attachment #8496634 -
Flags: review?(standard8)
Attachment #8496634 -
Flags: review+
Attachment #8496634 -
Flags: approval-comm-beta+
Attachment #8496634 -
Flags: approval-comm-aurora+
Assignee | ||
Comment 7•10 years ago
|
||
Thanks.
Tree's closed currently, so setting checkin-needed in case someone gets to landing this before I do.
Keywords: checkin-needed
Assignee | ||
Comment 8•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Target Milestone: --- → Thunderbird 36.0
Updated•10 years ago
|
Keywords: checkin-needed
Comment 9•10 years ago
|
||
This already landed on aurora:
https://hg.mozilla.org/releases/comm-aurora/rev/e97c2afe7c85
status-thunderbird35:
--- → fixed
Comment 10•10 years ago
|
||
Updated•10 years ago
|
status-thunderbird34:
--- → fixed
Updated•10 years ago
|
status-thunderbird36:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•