Closed Bug 1074011 Opened 10 years ago Closed 10 years ago

Thunderbird's preprocessed channel-prefs.js file needs to be the same for each build

Categories

(Thunderbird :: Installer, defect)

All
macOS
defect
Not set
normal

Tracking

(thunderbird34 fixed, thunderbird35 fixed, thunderbird36 fixed)

RESOLVED FIXED
Thunderbird 36.0
Tracking Status
thunderbird34 --- fixed
thunderbird35 --- fixed
thunderbird36 --- fixed

People

(Reporter: robert.strong.bugs, Assigned: jsbruner)

References

Details

Attachments

(1 file)

Attached patch patch (deleted) — Splinter Review
I won't be able to drive this patch into the tree
Josiah, can you test and finish this?
Flags: needinfo?(josiah)
I should be able to, yes. Assigning to myself so I don't forget.
Assignee: nobody → josiah
Flags: needinfo?(josiah)
Comment on attachment 8496634 [details] [diff] [review] patch Review of attachment 8496634 [details] [diff] [review]: ----------------------------------------------------------------- This looks fine to me, but I don't really know what the GARBAGE stuff does, and that part isn't part of the Fx or SM patch, so I don't feel confident reviewing this. So I'm going to let Standard8 review it.
Attachment #8496634 - Flags: review?(standard8)
Comment on attachment 8496634 [details] [diff] [review] patch Ok, looks good. I'm pretty sure this is needed on aurora & beta, so a=me for landing on those. Please flag any other patches that we need as well.
Attachment #8496634 - Flags: review?(standard8)
Attachment #8496634 - Flags: review+
Attachment #8496634 - Flags: approval-comm-beta+
Attachment #8496634 - Flags: approval-comm-aurora+
Thanks. Tree's closed currently, so setting checkin-needed in case someone gets to landing this before I do.
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 36.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: