Closed Bug 1071134 Opened 10 years ago Closed 10 years ago

Fix command line help for updater

Categories

(Toolkit :: Application Update, defect)

Product:
Toolkit
Component:
Application Update
Platform:
x86_64
Windows 8.1
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla35
Tracking Flags:
Tracking Status
firefox34 --- fixed
firefox35 --- fixed

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

References

(
URL
)

Details

Attachments

(1 file, 1 obsolete file)

patch - addressed comment
(deleted), patch
robert.strong.bugs
: review+
Details | Diff | Splinter Review
For Mac v2 signing an additional command line param was added. Now it should be fprintf(stderr, "Usage: updater patch-dir install-dir apply-to-dir [wait-pid [callback-working-dir callback-path args...]]\n"); This bug will fix that and the documentation
Attached patch pach rev1 (obsolete) (deleted) — — Splinter Review
Attachment #8493250 - Flags: review?(spohl.mozilla.bugs)
Comment on attachment 8493250 [details] [diff] [review] pach rev1 Review of attachment 8493250 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/mozapps/update/updater/updater.cpp @@ +2227,5 @@ > InitProgressUI(&argc, &argv); > > // To process an update the updater command line must at a minimum have the > + // directory path containing the updater.mar file to process as the first > + // argument the install directory as the second argument, and the directory to nit: a comma after "[...] updater.mar file to process as the first argument" might help readability.
Attachment #8493250 - Flags: review?(spohl.mozilla.bugs) → review+
Attached patch patch - addressed comment (deleted) — — Splinter Review
Attachment #8493250 - Attachment is obsolete: true
Attachment #8493260 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/818b73513ce2
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Landed on aurora in the Mac V2 signing combined patch in bug 1047584
status-firefox34: --- → fixed
status-firefox35: --- → fixed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: