Closed Bug 1074627 Opened 10 years ago Closed 10 years ago

Modify update verify scripts for new updater arg

Categories

(Release Engineering :: Release Automation: Other, defect, P2)

x86
All
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: nthomas, Assigned: nthomas)

References

Details

Attachments

(2 files, 1 obsolete file)

Bug 1071134 describes the changes made to the updater executable to support mac v2 signing. We'll probably need to adjust http://hg.mozilla.org/build/tools/file/83156a061339/release/common/check_updates.sh#l49 prior to 34.0b2.
The tricky thing here might be coping with the old and the new style at the same time, since they have a different number of required args.
Temporary fix for update_verify errors
Attachment #8508718 - Flags: review?(bhearsum)
Attachment #8508718 - Flags: review?(bhearsum) → review+
Temporary fix landed, updated tags, and then backed it out. We need a more generic solution for this problem.
Works on my laptop (mac), need to test on other platforms. Removes support of previous calling style, which was used up to Firefox 3.6.
Assignee: nobody → nthomas
Attachment #8508718 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Comment on attachment 8509199 [details] [diff] [review] [tools] Use old calling style for Gecko < 34 mgerva, thanks for the first hunk of this. The whole thing has tested fine on win32/mac/linux64 using a truncated beta config (just one locale, 33.0b9 and 34.0b1 -> 34.0b2). Hopefully we can get it landed before 34.0b3 starts. I'm removing the previous use of use_old_updater, which was a global from the command line, since it was used for Firefox older than v4.0. We don't need to do update verify for that any more. It becomes a variable we reset after each line is read from the config, depending on the version we're testing this time. Callek, did I map Gecko 34 to the SeaMonkey version correctly ?
Attachment #8509199 - Flags: review?(mgervasini)
Attachment #8509199 - Flags: feedback?(bugspam.Callek)
Attached file Windows log (deleted) —
Attachment #8510164 - Attachment mime type: text/x-log → text/plain
Comment on attachment 8509199 [details] [diff] [review] [tools] Use old calling style for Gecko < 34 Great, thanks Nick! Callek, I have r+ and landed this. We are expecting a build3 soon but if there are any issues with SeaMonkey version mappings, I'll be happy to fix them.
Attachment #8509199 - Flags: review?(mgervasini)
Attachment #8509199 - Flags: review+
Attachment #8509199 - Flags: checked-in+
Attachment #8509199 - Flags: feedback?(bugspam.Callek) → feedback+
Worked for Firefox 34.0b3 build2 and 33.0.1 build2.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: