Closed Bug 1071431 Opened 10 years ago Closed 10 years ago

[Ringtones] Settings would crash when select a mp3 file (>2000KB) as ringtone/alert

Categories

(Core :: Audio/Video, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Tracking Status
b2g-v2.0 --- unaffected
b2g-v2.1 --- unaffected
b2g-v2.2 --- verified

People

(Reporter: ashiue, Assigned: rlin)

References

Details

(Keywords: crash, regression)

Crash Data

Attachments

(2 files)

Attached file settings_crash.log (deleted) —
Gaia-Rev 3c898380b47f298cd3b7a0dacb3a6529e94322d4 Gecko-Rev https://hg.mozilla.org/mozilla-central/rev/4cdc4b9e5832 Build-ID 20140922184244 Version 35.0a1 Prerequisite: a mp3 file (> 2000KB) in SD card STR: 1. Insert SD on device 2. Go to Settings -> Sound -> Tones 3. Select the mpe file as ringtone Expect result: Set the mp3 file as ringtone succedssfully Actual result: Settings crashed
Attached audio [MP3 (Audio)]test.mp3 (deleted) —
The attached audio for crashing Settings (http://youtu.be/AVc6e9a5dKI)
blocking-b2g: --- → 2.2?
QA Whiteboard: [COM=Gaia::Ringtones]
Did this just recently start failing? Whenever I've manually tested this feature, I've used mp3s in the 8-10 MB range, and it's always worked.
I flashed KK build on tinderbox to the test device. I tried several 2.2 previous version builds, and found before 20140916162300 build on tinderbox, no crash problem. Gaia-Rev 50666fa8bbbf3d346faff24f92ad8140a44a49d0 Gecko-Rev https://hg.mozilla.org/mozilla-central/rev/49ef7b18963d Build-ID 20140916162300 Version 35.0a1 (*2.1 latest version works fine)
Well, I don't think this is a ringtones issue, since you can create a new ringtone from the ringtone manager, and it will get successfully set as the default, but if you try to set it via the picker, it crashes. It also seems to work fine for Ogg Vorbis files, and I don't think we do anything special with MP3 files that would cause a crash. My guess, based on the date it broke, is that this is from bug 1065128. Kyle: Any ideas?
Flags: needinfo?(kyle)
Does settings crash here mean the settings app crashed, or that you're getting a stack that involves settings DOM API calls somewhere? I see nothing relevant to the settings API on the logcat. If there were some sort of permissions issues (like bug 1065128 had), we should see errors before the app was killed. In the middle of the log messages of the first crash, there's a E/OomLogger( 206): [Kill]: lowmem_shrink: convert oom_adj to oom_score_adj: Did something get OOM'd? What device was this test done on?
Flags: needinfo?(kyle)
Hmm, I investigated a bit further and it seems that it's a decoder issue, not a settings issue. Based on the blame, it looks like bug 1039901 is the culprit. Sorry for the incorrect guess in comment 4!
Blocks: 1039901
Crash Signature: 918023cc-8be0-4475-a4d4-49fb92140923
Flags: needinfo?(rlin)
Hi ashiue, Could you upload the crash report for me to ensure the root-cause? you can run adb pull /data/b2g/mozilla/Crash\ Reports . and update dump file on this bug. After running minidump_stackwalk, I guess it should look like Thread 0 (crashed) 0 libxul.so!mozilla::MediaOmxReader::NotifyDataArrived(char const*, unsigned int, long long) [MediaOmxReader.cpp:790f41c631cc : 463 + 0x2] r0 = 0xb355b784 r1 = 0x00000000 r2 = 0x00000001 r3 = 0x5a5a5a5a r4 = 0xd85d654b r5 = 0x00000000 r6 = 0xb1a81800 r7 = 0xb1a81978 r8 = 0x00008000 r9 = 0xb0e51000 r10 = 0x00008000 r12 = 0x00000001 fp = 0xb6859f40 sp = 0xbec79d68 lr = 0xb6aa505b pc = 0xb584f116
Flags: needinfo?(ashiue)
(In reply to Randy Lin [:rlin] from comment #7) > Hi ashiue, > Could you upload the crash report for me to ensure the root-cause? Did you see the crash signature I attached to this bug?
Got it and take it. thanks
Flags: needinfo?(rlin)
Flags: needinfo?(ashiue)
QA Contact: rlin
(In reply to Randy Lin [:rlin] from comment #9) > Got it and take it. thanks Did you mean to assign this to yourself? You're just the QA Contact now...
Component: Gaia::Ringtones → Video/Audio
Product: Firefox OS → Core
See the attached MP3 file. Adding qawanted for branch checks.
Keywords: qawanted
Assignee: nobody → rlin
QA Contact: rlin
QA Contact: aalldredge
Unable to check in latest Flame 2.2 Master because issue was blocked by Bug 1076975. Checked in Master build on the date the issue was reported. --------------------------------------- This issue occurs in 2.2 Flame. Environmental Variables: Device: Flame 2.2 Master (Shallow Flash) BuildID: 20140922115028 Gaia: e1fd99454b6cd5da4f2c58f928fc04c6d03f478f Gecko: af668f4b96c8 Version: 35.0a1 (2.2 Master) Firmware: V180 User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0 Result: Settings crashed after setting mp3 as ringtone. -------------------------------------------------------------- This issue does not occur in 2.1 Flame or 2.0 Flame. Environmental Variables: Device: Flame 2.1 (Shallow Flash) BuildID: 20141001123325 Gaia: c1cc61e30f5cb3446f1692ff9fd1e32232f6a231 Gecko: 4ff49aa32213 Version: 34.0a2 (2.1) Firmware: V180 User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0 Device: Flame 2.0 (Shallow Flash) BuildID: 20141001123531 Gaia: 8079cba2133e6f5443dba24dad077f7f91e6c978 Gecko: 3a656e533675 Version: 32.0 (2.0) Firmware: V180 User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0 Result: The mp3 was set as ringtone correctly.
QA Whiteboard: [COM=Gaia::Ringtones] → [COM=Gaia::Ringtones], [QAnalyst-Triage?]
Flags: needinfo?(jmitchell)
Keywords: qawantedregression
QA Whiteboard: [COM=Gaia::Ringtones], [QAnalyst-Triage?] → [COM=Gaia::Ringtones], [QAnalyst-Triage+]
Depends on: 1076975
Flags: needinfo?(jmitchell)
The same problem as bug 1069602. Duplicate with it.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
Verified on Gaia-Rev 3b81896f04a02697e615fa5390086bd5ecfed84f Gecko-Rev https://hg.mozilla.org/mozilla-central/rev/199fb29c3467 Build-ID 20141012160201 Version 35.0a1
Status: RESOLVED → VERIFIED
Resolution: DUPLICATE → FIXED
Depends on: 1087464
blocking-b2g: 2.2? → ---
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: