Closed Bug 1074043 Opened 10 years ago Closed 10 years ago

Status bar icons have wrong color when using activities

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.1+, b2g-v2.1 verified, b2g-v2.2 verified)

Status:
VERIFIED FIXED
Milestone:
2.1 S6 (10oct)
Project Flags:
blocking-b2g 2.1+
Tracking Flags:
Tracking Status
b2g-v2.1 --- verified
b2g-v2.2 --- verified

People

(Reporter: gwagner, Assigned: aus)

References

Details

(Whiteboard: [systemsfe][p=1])

Attachments

(4 files)

Screenshot - Current State in 2.1
(deleted), image/png
Details
Screenshot - Stuck with bad colour
(deleted), image/png
Details
Pull Request - Listen for activity creation and update titlebar style as expected
(deleted), text/x-github-pull-request
etienne
: review+
bajaj
: approval-gaia-v2.1+
Details
Pull Request - v2.1
(deleted), text/x-github-pull-request
Details
STR: Open page in browser and share via message app.
[Blocking Requested - why for this release]:
blocking-b2g: --- → 2.1?
Whiteboard: [systemsfe]
Bad UX
blocking-b2g: 2.1? → 2.1+
Assignee: nobody → aus
Target Milestone: --- → 2.1 S6 (10oct)
Looking into this today.
Status: NEW → ASSIGNED
Attached image Screenshot - Current State in 2.1 (deleted) —
Attached image Screenshot - Stuck with bad colour (deleted) —
Attachment #8497052 - Flags: review?(mhenretty) → review?(alive)
Whiteboard: [systemsfe] → [systemsfe][p=1]
Blocks: 1074352
No longer blocks: 1074352
Comment on attachment 8497052 [details] Pull Request - Listen for activity creation and update titlebar style as expected As discussion on IRC we tend to use 'activityopening'/'activityopened' event. Also, in *opening/*opened handler, we should use app.getTopMostWindow() to get the information of the correct app window instance to change the color of statusbar.
Attachment #8497052 - Flags: review?(alive)
Attachment #8497052 - Flags: review?(etienne)
Comment on attachment 8497052 [details] Pull Request - Listen for activity creation and update titlebar style as expected r=me with the test comment addressed
Attachment #8497052 - Flags: review?(etienne) → review+
Comment on attachment 8497052 [details] Pull Request - Listen for activity creation and update titlebar style as expected [Approval Request Comment] [Bug caused by] (feature/regressing bug #): New Status Bar UX [User impact] if declined: Status Bar icons will use the dark theme instead of the light theme. This makes them barely legible at best. [Testing completed]: On Device (Flame 319M / v180 + Latest Gecko and Gaia) + Unit Tests. [Risk to taking this patch] (and alternatives if risky): Low. It's a very isolated change backed by tests and manual testing. [String changes made]: None.
Attachment #8497052 - Flags: approval-gaia-v2.1?(fabrice)
Commit (master): https://github.com/mozilla-b2g/gaia/commit/22b1698a71db620b1dd04867aba55efbfd9f23d7 Fixed!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-b2g-v2.1: --- → affected
status-b2g-v2.2: --- → fixed
Resolution: --- → FIXED
QA Whiteboard: [QAnalyst-Triage?]
status-b2g-v2.2: fixed → verified
Flags: needinfo?(ktucker)
This issue is verified on Flame 2.2: Flame 2.2 KitKat Base (319mb)(Full Flash) Environmental Variables: Device: Flame 2.2 Master BuildID: 20141001040205 Gaia: 0e280591881d44b80f456bc27e12d9114c218868 Gecko: 14665b1de5ee Gonk: 2c909e821d107d414f851e267dedcd7aae2cebf Version: 35.0a1 (2.2 Master) Firmware: V180 User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0 The status bar icons are displayed in white after returning from Message app.
Attachment #8497052 - Flags: approval-gaia-v2.1?(fabrice) → approval-gaia-v2.1+
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
This issue is verified on Flame 2.1 as well: Flame 2.1 KitKat Base (319mb)(Full Flash) Environmental Variables: Device: Flame 2.1 BuildID: 20141003000203 Gaia: 9861c61ec302fb0316c753a2e1c0f592180515fd Gecko: da68900d1c66 Gonk: 2c909e821d107d414f851e267dedcd7aae2cebf Version: 34.0a2 (2.1) Firmware: V180 User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0 The status bar icons are displayed in white after returning from Message app.
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage?]
status-b2g-v2.1: fixed → verified
Flags: needinfo?(ktucker)
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
Blocks: 1082457
Flags: in-testsuite?
Flags: in-testsuite? → in-testsuite+
Depends on: 1100714
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: