Closed
Bug 1081346
Opened 10 years ago
Closed 10 years ago
Status Bar is white on white after adding bookmark to the homescreen
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(blocking-b2g:2.1+, b2g-v2.1 verified, b2g-v2.2 verified)
People
(Reporter: gwagner, Assigned: aus)
References
Details
(Whiteboard: [systemsfe][p=1])
Attachments
(2 files)
(deleted),
image/png
|
Details | |
(deleted),
text/x-github-pull-request
|
alive
:
review+
alive
:
feedback+
bajaj
:
approval-gaia-v2.1+
|
Details |
On 2.1:
STR:
Open page in browser
Add to homescreen
Reporter | ||
Updated•10 years ago
|
Whiteboard: [systemsfe]
Reporter | ||
Comment 3•10 years ago
|
||
[Blocking Requested - why for this release]:
Bad UX
blocking-b2g: --- → 2.1?
Comment 4•10 years ago
|
||
Caused by bug 1074043. Probably just need to make sure we set the icon color when closing activities too.
Blocks: 1074043
Assignee | ||
Comment 5•10 years ago
|
||
(In reply to Michael Henretty [:mhenretty] from comment #4)
> Caused by bug 1074043. Probably just need to make sure we set the icon color
> when closing activities too.
Yep! I can whip up a patch for this easily.
Comment 7•10 years ago
|
||
Assigning over to :aus since he knows this code way better than I.
Assignee: mhenretty → aus
Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [systemsfe] → [systemsfe][p=1]
Assignee | ||
Comment 8•10 years ago
|
||
A small detail forgotten when I fixed part of this issue before... What happens to the icons when the activity terminates and returns to an application with a completely different theme? *sigh*
Attachment #8503511 -
Flags: review?(alive)
Assignee | ||
Updated•10 years ago
|
status-b2g-v2.1:
--- → affected
status-b2g-v2.2:
--- → affected
Comment 9•10 years ago
|
||
FWIW, this fixes the issue for me. Just heads up, the statusbar_test.js unit test will have to be fixed before landing.
Thanks for fixing this so fast!
Comment 10•10 years ago
|
||
Comment on attachment 8503511 [details]
Pull Request - Update status bar appearance on activity termination.
This fix is valid, but my question: why the activityclosed handler does not set the appearance well? I need to know what's wrong with it.
Attachment #8503511 -
Flags: review?(alive) → feedback+
Comment 11•10 years ago
|
||
(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #10)
> Comment on attachment 8503511 [details]
> Pull Request - Update status bar appearance on activity termination.
>
> This fix is valid, but my question: why the activityclosed handler does not
> set the appearance well? I need to know what's wrong with it.
Hmm..looks like we never use activityclosed event. And even with this event we could not use it to change the appearance..
We should have/use appforeground event in the future if we are getting rid of the setVisible struggle.
Aus, please add unit test for your patch and ask review again, thanks.
Updated•10 years ago
|
Target Milestone: --- → 2.1 S7 (Oct24)
Assignee | ||
Comment 12•10 years ago
|
||
Comment on attachment 8503511 [details]
Pull Request - Update status bar appearance on activity termination.
I added a new test to ensure this functionality doesn't regress. The logic is a little complex so I also added some comments to avoid confusion later.
Attachment #8503511 -
Flags: review?(alive)
Comment 13•10 years ago
|
||
Comment on attachment 8503511 [details]
Pull Request - Update status bar appearance on activity termination.
r=me
Attachment #8503511 -
Flags: review?(alive) → review+
Assignee | ||
Comment 14•10 years ago
|
||
Commit (master): https://github.com/mozilla-b2g/gaia/commit/ec355e1c02ebffbfda778661c2501a0bc78317dc
Fixed!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 15•10 years ago
|
||
Comment on attachment 8503511 [details]
Pull Request - Update status bar appearance on activity termination.
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): New feature (new status bar with color theming)
[User impact] if declined: Icons become unreadable until user returns to homescreen or opens another application.
[Testing completed]: On device (Flame 319M v184), robust unit-tests
[Risk to taking this patch] (and alternatives if risky): Low. Tests cover regression potential.
[String changes made]: None.
Attachment #8503511 -
Flags: approval-gaia-v2.1?
Updated•10 years ago
|
Attachment #8503511 -
Flags: approval-gaia-v2.1? → approval-gaia-v2.1+
Updated•10 years ago
|
Flags: in-testsuite? → in-testsuite+
Comment 16•10 years ago
|
||
Comment 17•10 years ago
|
||
Issue is verified fixed in Flame 2.2, 2.1 (Full Flash, nightly).
Actual Results: Status Bar UI behaves correctly when user saves web page to homescreen.
Device: Flame Master
Build ID: 20141017040208
Gaia: abef62c0623e5504a97b4fd411e879a67b285b52
Gecko: ae1dfa192faf
Version: 36.0a1 (Master)
Firmware Version: v180
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0
Device: Flame 2.1
Build ID: 20141017001201
Gaia: 1ea74943cfe525c76a074ca1d7de8e51a70f6b98
Gecko: 2befa902ff5c
Version: 34.0 (2.1)
Firmware Version: v180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
Updated•10 years ago
|
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
You need to log in
before you can comment on or make changes to this bug.
Description
•