Closed
Bug 1075136
Opened 10 years ago
Closed 10 years ago
Initialize TileClient::mCompositableClient correctly
Categories
(Core :: Graphics: Layers, defect)
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: sotaro, Assigned: sotaro)
References
Details
Attachments
(2 files)
(deleted),
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
(deleted),
text/plain
|
Details |
TileClient::mCompositableClient is not initialized to a correct value. By it, RemoveTextureFromCompositableTracker is not used correctly.
It could cause tiled layer rendering's tearing/flickering problem.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → sotaro.ikeda.g
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8497757 -
Flags: review?(nical.bugzilla)
Updated•10 years ago
|
Attachment #8497757 -
Flags: review?(nical.bugzilla) → review+
Assignee | ||
Comment 2•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Comment 4•10 years ago
|
||
Commit https://hg.mozilla.org/integration/mozilla-inbound/rev/f54ea093e836 is causing failures in our automation: http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk-319.b2g-inbound.ui.functional.smoke/316/HTML_Report/
We have test_clock_create_new_alarm.py failing because of this.
Can you please back it out? Thanks!
Flags: needinfo?(cbook)
Assignee | ||
Updated•10 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 5•10 years ago
|
||
STR to replicate the failure manually:
1. Launch Clock app
2. Tap Add new alarm button
#Expected results:
Add new alarm page is displayed
#Actual results:
Clock app is closed and we are redirected to Homescreen
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 6•10 years ago
|
||
See also http://logs.glob.uno/?c=mozilla%23gfx&s=2%20Oct%202014&e=2%20Oct%202014#c203163 - :gerard-majax was seeing an error (the attachment shows the contents of his pastebin link, in case it expires) and this is the most likely change to have introduced the problem given his regression range.
Assignee | ||
Comment 8•10 years ago
|
||
backout |
Assignee | ||
Comment 9•10 years ago
|
||
(In reply to Sotaro Ikeda [:sotaro] from comment #8)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/64ec6cd769a6
backed out
Assignee | ||
Comment 10•10 years ago
|
||
TiledContentClient has a problem of how to call RemoveTextureFromCompositableAsync(). It caused the problem. This bug's commit just increase the frequency of the function call. Therefore the problem exist as a hidden problem even in current gecko. At first, this IPC problem should be addressed.
Assignee | ||
Comment 11•10 years ago
|
||
(In reply to Sotaro Ikeda [:sotaro] from comment #10)
> TiledContentClient has a problem of how to call
> RemoveTextureFromCompositableAsync(). It caused the problem. This bug's
> commit just increase the frequency of the function call. Therefore the
> problem exist as a hidden problem even in current gecko. At first, this IPC
> problem should be addressed.
Bug 1076868 handles the ipc problem.
Comment 12•10 years ago
|
||
Tested the mozilla-inbound back out build and our tests work as expected
Thanks for fixing this all
Gaia-Rev 191d805f4911628d37a8a90a1e23a6013995138f
Gecko-Rev https://hg.mozilla.org/integration/mozilla-inbound/rev/64ec6cd769a6
Build-ID 20141002064626
Version 35.0a1
Device-Name flame
FW-Release 4.4.2
FW-Incremental eng.cltbld.20141002.095610
FW-Date Thu Oct 2 09:56:21 EDT 2014
Bootloader L1TC10011800
Comment 13•10 years ago
|
||
Merge of the backout:
https://hg.mozilla.org/mozilla-central/rev/64ec6cd769a6
Assignee | ||
Comment 16•10 years ago
|
||
Assignee | ||
Comment 17•10 years ago
|
||
Bug 1076868 was fixed. The STR in comment 5 does not cause the problem when applying the patch.
Assignee | ||
Comment 18•10 years ago
|
||
Assignee | ||
Comment 19•10 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•