Closed
Bug 1079220
Opened 10 years ago
Closed 10 years ago
Modify file structure of Instantbird to match toolkit changes
Categories
(Instantbird Graveyard :: Other, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.6
People
(Reporter: clokep, Assigned: florian)
Details
Attachments
(3 files, 4 obsolete files)
|
(deleted),
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1074002, Bug #1074006 +++
Port of bug 1047584 for Thunderbird
Maybe also bug 1074011
|
Reporter | |
Comment 1•10 years ago
|
||
|
|
Reporter | |
Comment 2•10 years ago
|
||
This patch is pretty broken since when I ported the changes over...well, let's just say our nsMain is pretty different from nsMail. Variables, etc. don't exist so the code doesn't actually compile.
|
|
Reporter | |
Comment 3•10 years ago
|
||
Attachment #8501010 -
Attachment is obsolete: true
|
Assignee | |
Comment 4•10 years ago
|
||
Here is my attempt at fixing attachment 8501032 [details] [diff] [review]. The application.ini stuff (especially around makefiles and crash report URL) isn't figured out yet.
Attachment #8501032 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•10 years ago
|
||
Comment on attachment 8501009 [details] [diff] [review]
Change app structure WIP
Review of attachment 8501009 [details] [diff] [review]:
-----------------------------------------------------------------
Fix the purplexpcom stuff, and the rest works.
::: im/installer/package-manifest.in
@@ +265,2 @@
> @BINPATH@/components/@DLL_PREFIX@purplexpcom@DLL_SUFFIX@
> +#endif
Please revert this change completely:
@BINPATH@/components/... is OK for Mac.
Attachment #8501009 -
Flags: review+
|
|
Assignee | |
Comment 6•10 years ago
|
||
This makes nsMain compile and work. It replaces attachment 8504006 [details] [diff] [review], and needs to be applied after clokep's attachment 8501032 [details] [diff] [review]. I'm attaching this mostly because it can be seen as an interdiff of the changes I did. Really what I did is make our nsMain.cpp match nsMailApp.cpp, except for the things that had a reason to be different.
Attachment #8504006 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 7•10 years ago
|
||
This is a patch we should actually check-in (ie. not an interdiff) if you r+ it.
With these changes, nsMain and nsMailApp are very close.
Assignee: nobody → florian
Attachment #8504329 -
Attachment is obsolete: true
Attachment #8504331 -
Flags: review?(clokep)
|
|
Assignee | |
Comment 8•10 years ago
|
||
Not the most beautiful hack ever, but I think that will do.
Attachment #8504349 -
Flags: review?(clokep)
|
|
Reporter | |
Updated•10 years ago
|
Attachment #8504349 -
Flags: review?(clokep) → review+
|
|
Reporter | |
Updated•10 years ago
|
Attachment #8504331 -
Flags: review?(clokep) → review+
|
||
Comment 9•10 years ago
|
||
|
|
||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.6
|
|
Assignee | |
Comment 10•10 years ago
|
||
Linux bustage fix: https://hg.mozilla.org/comm-central/rev/a0b9e4da8ee2
|
|
Reporter | |
Comment 11•10 years ago
|
||
Follow-up to match Thunderbird: https://hg.mozilla.org/comm-central/rev/42c2ad43b52d
(Ports https://hg.mozilla.org/comm-central/rev/cb0d7be5a15c)
|
||
Comment 12•10 years ago
|
||
Commit pushed to master at https://github.com/mozilla/web-platform-compat
https://github.com/mozilla/web-platform-compat/commit/5a237c51384cfa541c9b34a1b590cbc8e4d5fa05
bug 1079220 - Parse Web/CSS/display
- Detect and error on unparsed Spec and Compat sections
- Parse <p>paragraphs</p> in table cells
- Better assembling of <code>one</code>, <code>two</code> feature names
- Handle canonical feature names in parsing and javascript
You need to log in
before you can comment on or make changes to this bug.
Description
•