Closed Bug 1079579 Opened 10 years ago Closed 10 years ago

Move the spidermonkey automation build scripts into the tree

Categories

(Release Engineering :: Applications: MozharnessCore, defect)

Product:
Release Engineering
Component:
Applications: MozharnessCore
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: sfink, Assigned: sfink)

References

Details

(Whiteboard: [easier-mozharness])

Attachments

(2 files, 3 obsolete files)

Move the automation build scripts into the tree
(deleted), patch
terrence
: review+
Details | Diff | Splinter Review
Call an in-tree script for spidermonkey jobs
(deleted), patch
terrence
: review+
Details | Diff | Splinter Review
It's much easier to figure out what broke the tests if the build/run script is in the tree. And this seems to be the general direction of most things these days.
Attached patch Move the automation build scripts into the tree (obsolete) (deleted) — — Splinter Review
Attached patch Call an in-tree script for spidermonkey jobs (obsolete) (deleted) — — Splinter Review
Whiteboard: [easier-mozharness]
Attached patch Call an in-tree script for spidermonkey jobs (obsolete) (deleted) — — Splinter Review
Do the buildbot stuff, then run the script from the source tree.
Attachment #8504826 - Flags: review?(terrence)
Attachment #8501413 - Attachment is obsolete: true
Move all the scripts into the tree.
Attachment #8504827 - Flags: review?(terrence)
Attachment #8501410 - Attachment is obsolete: true
Comment on attachment 8504827 [details] [diff] [review] Move the automation build scripts into the tree Review of attachment 8504827 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/devtools/automation/autospider.sh @@ +124,5 @@ > +fi > + > +$COMMAND_PREFIX $MAKE check || exit 1 > +$COMMAND_PREFIX $MAKE check-jit-test || exit 1 > +$COMMAND_PREFIX $MAKE check-jstests || exit 1 I guess this is the line that turns out to be a nop currently?
Attachment #8504827 - Flags: review?(terrence) → review+
Attachment #8504826 - Flags: review?(terrence) → review+
Comment on attachment 8504826 [details] [diff] [review] Call an in-tree script for spidermonkey jobs Review of attachment 8504826 [details] [diff] [review]: ----------------------------------------------------------------- Then again, r- from me. I just realized that if I land this as-is, I will break all of the spidermonkey builds for the older trees.
Attachment #8504826 - Flags: review+ → review-
Keywords: leave-open
Smaller patch. Call the in-tree version if it exists.
Attachment #8507237 - Flags: review?(terrence)
Attachment #8504826 - Attachment is obsolete: true
Attachment #8507237 - Flags: review?(terrence) → review+
Keywords: leave-open
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: