[Blocking Requested - why for this release]: +++ This bug was initially created as a clone of Bug #1074123 +++ spinning a new bug up, as this is likely a recent regression. The SHB is clipping the OTA update confirmation screen. See screenshot. Repro: 1) install a 10/15 image on 2.1 branch build on Flame Kitkat Gaia-Rev 379ea4c9dd6d3f8ca2f79ce59c15f6afe6e557c3 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/4853208cb48a Build-ID 20141015001201 Version 34.0 Device-Name flame FW-Release 4.4.2 FW-Incremental eng.cltbld.20141011.032649 FW-Date Sat Oct 11 03:26:59 EDT 2014 Bootloader L1TC00011840 2) settings > developer > enable soft home button 3) settings > check for updates 4) apply update that is found from dropdown status bar 5) Verify the OTA check screen is covered by the Soft home button Expected: - screen is scaled and not clipping buttons Actual: - buttons clipped

Broken feature

Taking.

Hey Mike - got time for a review? Thanks!

Comment on attachment 8507196 [details] Github pull request This breaks the crash reporter dialog (#crash-dialog). The problem is that some dialogs take up the entire screen, and some use the layout manager to set a static pixel height. So we can't set bottom property across all confirm dialogs. I think putting something like this into core.css would work here: #screen > #dialog-screen { bottom: var(SHB-height); }

Comment on attachment 8507196 [details] Github pull request Mike - good call, I suppose being more explicit is best. I've gone ahead and added a hook to core.css as suggested. Let me know what you think.

Comment on attachment 8507196 [details] Github pull request LGTM. Nice test too. Thanks!

In master: https://github.com/mozilla-b2g/gaia/commit/f3cf5187520cdae91cb2b20583efc9fc294432bc

Comment on attachment 8507196 [details] Github pull request [Approval Request Comment] [Bug caused by] (feature/regressing bug #): Feature implementation. [User impact] if declined: Poor experience using the software home button when installing updates. [Testing completed]: Manual and integration test. [Risk to taking this patch] (and alternatives if risky): Low risk as this fix in particular is tied to the id. It should not regress other implementations. [String changes made]: None.

v2.1: https://github.com/mozilla-b2g/gaia/commit/e458f5804c0851eb4e93c9eb143fe044988cecda

Issue verified fixed on Flame 2.1 and Flame 2.2 Actual Results: Confirmation buttons on OTA installation screen are not covered by Software Home Button. Crash confirmation buttons are not covered by SHB. Device: Flame 2.1 KK (319mb) (Full Flash) BuildID: 20141021001201 Gaia: e458f5804c0851eb4e93c9eb143fe044988cecda Gecko: ee86921a986f Gonk: 05aa7b98d3f891b334031dc710d48d0d6b82ec1d Version: 34.0 (2.1) Firmware: V188 User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0 Device: Flame 2.2 Master KK (319mb) (Full Flash) BuildID: 20141021040206 Gaia: 457a54fc3200b80e4f5e1cd3acaa062309230732 Gecko: 29fbfc1b31aa Gonk: 05aa7b98d3f891b334031dc710d48d0d6b82ec1d Version: 36.0a1 (2.2 Master) Firmware: V188 User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0