Closed
Bug 1077579
Opened 10 years ago
Closed 10 years ago
[meta] SHB issue tracking
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mikehenrty, Unassigned)
References
Details
(Keywords: meta, Whiteboard: [systemsfe])
User Story
Still need tests for the following: * bug 1068470 * bug 1074123 * bug 1078904 * bug 1078911 * bug 1068470 * bug 1072728
Attachments
(9 files)
(deleted),
text/x-github-pull-request
|
Details | |
(deleted),
text/x-github-pull-request
|
Details | |
(deleted),
text/x-github-pull-request
|
Details | |
(deleted),
text/x-github-pull-request
|
Eli
:
review+
|
Details |
(deleted),
text/x-github-pull-request
|
Details | |
(deleted),
text/x-github-pull-request
|
Details | |
(deleted),
text/x-github-pull-request
|
mikehenrty
:
review+
Eli
:
review+
|
Details |
(deleted),
text/x-github-pull-request
|
Details | |
(deleted),
text/x-github-pull-request
|
Details |
Let's use this meta bug to track all the SHB issues we've been seeing in 2.1, and write tests for as many problems as we can.
Please help out by adding any SHB bugs to this tracker.
Updated•10 years ago
|
Flags: needinfo?(kgrandon)
Comment 1•10 years ago
|
||
This is still a WIP. I'd like to add some more assertions to check general height and layout of elements.
Flags: needinfo?(kgrandon)
Updated•10 years ago
|
Attachment #8499810 -
Attachment description: Pull request - Coverage for bug 1074580 → Pull request - Coverage for bug 1074580, part 1
Comment 2•10 years ago
|
||
Comment on attachment 8499810 [details]
Pull request - Coverage for bug 1074580
Mike - these are not perfect, but they are a start. I'd like to land these for now and we should be able to continue to iterate on them.
The biggest thing right now is that I have to figure out what's going on with bug 1077700. Once that's solved I'll revisit these and add some more assertions. let me know what you think.
Attachment #8499810 -
Flags: review?(mhenretty)
Comment 3•10 years ago
|
||
Comment on attachment 8499810 [details]
Pull request - Coverage for bug 1074580
I've made some updates and this should fully cover bug 1074580 now. I forgot that the requestFullScreen() had to be based on user action.
Attachment #8499810 -
Attachment description: Pull request - Coverage for bug 1074580, part 1 → Pull request - Coverage for bug 1074580
Comment 4•10 years ago
|
||
Comment 5•10 years ago
|
||
Comment on attachment 8499810 [details]
Pull request - Coverage for bug 1074580
Eli - Could you also take a look at this if you have time? Thanks!
Attachment #8499810 -
Flags: review?(eperelman)
Comment 6•10 years ago
|
||
Comment 7•10 years ago
|
||
Comment on attachment 8499894 [details]
Pull request - Coverage for bug 1072231
Moving the review to the pull request that has more tests. (This is inclusive of the other two here)
Attachment #8499894 -
Flags: review?(mhenretty)
Attachment #8499894 -
Flags: review?(eperelman)
Updated•10 years ago
|
Attachment #8499810 -
Flags: review?(mhenretty)
Attachment #8499810 -
Flags: review?(eperelman)
Comment 8•10 years ago
|
||
This makes tests for: 1074580, 1048593, and 1072231.
Tests are required for the following bugs still: 1068470, 1074123, 1064595, 1074608
Updated•10 years ago
|
Attachment #8499894 -
Attachment description: Pull request - Coverage for bug 107223 → Pull request - Coverage for bug 1072231
Comment 9•10 years ago
|
||
Adding a patch to cover bug 1064595.
Tests are required for the following bugs still: 1068470, 1074123, 1074608
Comment 10•10 years ago
|
||
Comment on attachment 8499900 [details]
Pull request - Coverage for bug 1064595
Moving reviews to latest bug which contains all tests.
Attachment #8499900 -
Flags: review?(mhenretty)
Attachment #8499900 -
Flags: review?(eperelman)
Updated•10 years ago
|
Attachment #8499894 -
Flags: review?(mhenretty)
Attachment #8499894 -
Flags: review?(eperelman)
Reporter | ||
Updated•10 years ago
|
Comment 11•10 years ago
|
||
Not sure of the best way to track these, so I'm going to use the user story.
Need tests for bugs: 1068470, 1074123, 1074608, 1005417, 1054716
User Story: (updated)
Updated•10 years ago
|
User Story: (updated)
Comment 12•10 years ago
|
||
Comment 13•10 years ago
|
||
Added a test for bug 1074608, but it appears the bug is still broken on master. Going to do some investigation.
User Story: (updated)
Updated•10 years ago
|
Attachment #8499900 -
Flags: review?(eperelman) → review+
Updated•10 years ago
|
User Story: (updated)
Comment 14•10 years ago
|
||
Comment on attachment 8499900 [details]
Pull request - Coverage for bug 1064595
Let's go with Eli's review for now. Thanks!
Attachment #8499900 -
Flags: review?(mhenretty)
Comment 15•10 years ago
|
||
Landing the individual pull requests (all with green gaia-try minus existing issues on trunk).
Test for bug 1074580: https://github.com/mozilla-b2g/gaia/commit/88796c385ab5ef32757a3ede5c86310ce6f0c538
Test for bug 1048593: https://github.com/mozilla-b2g/gaia/commit/3e1481c1447a27b52b8c407e788cae7ba7987c8c
Test for bug 1072231: https://github.com/mozilla-b2g/gaia/commit/e28849c517ce92b57ae788062322ca4ba3c1579c
Test for bug 1064595: https://github.com/mozilla-b2g/gaia/commit/79afd14f4ddd959a1300d1e1be126879d711ba12
Comment hidden (obsolete) |
Comment 17•10 years ago
|
||
Updated•10 years ago
|
User Story: (updated)
Updated•10 years ago
|
User Story: (updated)
Comment hidden (obsolete) |
Comment hidden (obsolete) |
Comment 20•10 years ago
|
||
Hey Mike or Eli - Could either of you guys review these patches? Thanks!
Attachment #8501252 -
Flags: review?(mhenretty)
Attachment #8501252 -
Flags: review?(eperelman)
Comment 21•10 years ago
|
||
Comment on attachment 8501252 [details]
Pull request - Coverage for bug 1075105
r+ for the SHB notification test.
Attachment #8501252 -
Flags: review?(eperelman) → review+
Reporter | ||
Comment 22•10 years ago
|
||
Comment on attachment 8501252 [details]
Pull request - Coverage for bug 1075105
Both tests looking good.
Attachment #8501252 -
Flags: review?(mhenretty) → review+
Comment 23•10 years ago
|
||
Test coverage for bug 1054716 landed: https://github.com/mozilla-b2g/gaia/commit/cae829b8891e46d416663381d5872db1cd391b55
User Story: (updated)
Comment 24•10 years ago
|
||
Test coverage for bug 1075105 landed: https://github.com/mozilla-b2g/gaia/commit/0bc74ce502672cf0265b24cf3a25d117c3de5e71
User Story: (updated)
Comment 25•10 years ago
|
||
Of the bugs blocking this one, only tests are needed for the current bugs which are open. I hope that we can land tests with the bug fixes, but if not I will monitor them here and ensure we get tests added for the future.
* bug 1068470
* bug 1074123
* bug 1078904
* bug 1078911
* bug 1068470
Updated•10 years ago
|
User Story: (updated)
Comment 26•10 years ago
|
||
Reporter | ||
Comment 27•10 years ago
|
||
Kevin, could you help me take a look at these Mocks tomorrow. Having trouble getting the System app to recognize them.
Comment 28•10 years ago
|
||
(In reply to Michael Henretty [:mhenretty] from comment #27)
> Created attachment 8502172 [details]
> [Gaia PR] Coverage for bug 1074123
>
> Kevin, could you help me take a look at these Mocks tomorrow. Having trouble
> getting the System app to recognize them.
Sure - if it's a blocker I suppose we can land without the tests. I'll be out tomorrow, but let's try on Friday..
Comment 29•10 years ago
|
||
Going to close this as we are now tracking testing with the in-testsuite flag for 2.1 blockers. The only remaining bug here is bug 1074123 which shows up in our queries. Go tests go!
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•