Recently something changed in the environment that run_jetpack.py runs in or the script itself which is causing all of the Jetpack tests to fail. https://tbpl.mozilla.org/php/getParsedLog.php?id=50473666&tree=Jetpack&full=1 https://tbpl.mozilla.org/php/getParsedLog.php?id=50474122&tree=Jetpack&full=1 https://tbpl.mozilla.org/php/getParsedLog.php?id=50520598&tree=Jetpack&full=1

We should be using https://github.com/mozilla/mozdownload here.

Comment on attachment 8507818 [details] [diff] [review] 2.diff Review of attachment 8507818 [details] [diff] [review]: ----------------------------------------------------------------- Jordan could you take a look at this for me too please?

Comment on attachment 8507818 [details] [diff] [review] 2.diff Review of attachment 8507818 [details] [diff] [review]: ----------------------------------------------------------------- I'm pretty unfamiliar with this code/logic so I'm probably not good to review. But it appears like it only affects jetpack jobs. If catlee or the reviewer has no complaints, I don't see the big deal with trying this out. You guys will know right away if something is wrong :) I think this would be nice to get into mozharness. the tools repo where this lives has only one branch, no staging environment to test, and is not nearly as feature complete for acting as a script harness.

Comment on attachment 8507818 [details] [diff] [review] 2.diff Review of attachment 8507818 [details] [diff] [review]: ----------------------------------------------------------------- looks ok to me as well...but do we have mozdownload available where this script is running?

(In reply to Chris AtLee [:catlee] from comment #6) > Comment on attachment 8507818 [details] [diff] [review] > 2.diff > > Review of attachment 8507818 [details] [diff] [review]: > ----------------------------------------------------------------- > > looks ok to me as well...but do we have mozdownload available where this > script is running? good point, I assumed it is available, I've only tried the script on osx with mozdownload installed globally. Like Jordan said though we can just try it and we'll find out and not hurt any other test suites. I'd like to know more about what is available on these test machines though, so any pointers would be awesome. When I requested a loaner slave previously it seemed like it was missing the run_jetpack.py file so I had to clone the repo and do some custom setup.

(In reply to Chris AtLee [:catlee] from comment #6) > Comment on attachment 8507818 [details] [diff] [review] > 2.diff > > Review of attachment 8507818 [details] [diff] [review]: > ----------------------------------------------------------------- > > looks ok to me as well...but do we have mozdownload available where this > script is running? Also I wasn't sure about the asan change https://bugzilla.mozilla.org/attachment.cgi?id=8507818&action=diff#a/buildfarm/utils/run_jetpack.py_sec3 I didn't see anything that fit quite right in https://github.com/mozilla/mozdownload/blob/master/mozdownload/scraper.py#L44-L57

(In reply to Chris AtLee [:catlee] from comment #6) > Comment on attachment 8507818 [details] [diff] [review] > 2.diff > > Review of attachment 8507818 [details] [diff] [review]: > ----------------------------------------------------------------- > > looks ok to me as well...but do we have mozdownload available where this > script is running? ah right, good point. taking a look at a linux slave that runs this(tst-linux64-spot-238), it seems like we do not have it available. Based upon our path used to call run_jetpack.py: PATH=/usr/local/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games python scripts/buildfarm/utils/run_jetpack.py -p ubuntu64_vm ... etc we are using the builtin and it does not have it (nor does the /tools python we sometimes use): [cltbld@tst-linux64-spot-238.test.releng.use1.mozilla.com ~]$ PATH=/usr/local/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games python -c 'import mozdownload' Traceback (most recent call last): File "<string>", line 1, in <module> ImportError: No module named mozdownload [cltbld@tst-linux64-spot-238.test.releng.use1.mozilla.com ~]$ /tools/buildbot/bin/python -c 'import mozdownload' Traceback (most recent call last): File "<string>", line 1, in <module> ImportError: No module named mozdownload we will have to either distribute that across all our machines (puppet + GPO?) by making this available to an existing interpreter or create a virtenv (which would mean we would have to upload mozdownload to our pypi server: http://pypi.pub.build.mozilla.org/pub/) Although, I still think the first step is to use mozharness. adding some modules and creating a virtualenv on the fly while the script runs is pretty trivial via mozharness. Obviously there will be a lot of work porting the script and reconfigin buildbot. I guess you'll have to weigh the cost and benefits. If it ain't broke, it might not be worth your time. :)