Closed
Bug 1085062
Opened 10 years ago
Closed 6 years ago
Remove hasXPConnectImpls support
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
Once EventTarget stops using it.
Assignee | ||
Comment 1•6 years ago
|
||
Attachment #8964756 -
Flags: review?(peterv)
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Comment 2•6 years ago
|
||
Comment on attachment 8964756 [details] [diff] [review] Remove hasXPConnectImpls support from bindings codegen Review of attachment 8964756 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/base/nsWrapperCache.h @@ +343,5 @@ > private: > // Friend declarations for things that need to be able to call > // SetIsNotDOMBinding(). The goal is to get rid of all of these, and > + // SetIsNotDOMBinding() too. Once that's done, we can remove the > + // couldBeDOMBinding bits in DoGetOrCreateDOMReflector, as well as any ither other ::: dom/bindings/BindingUtils.cpp @@ +1232,5 @@ > } > > // Switch this to UnwrapDOMObjectToISupports once our global objects are > // using new bindings. > + nsCOMPtr<nsISupports> native = UnwrapDOMObjectToISupports(obj); Please remove the comment. ::: dom/bindings/Codegen.py @@ -1986,5 @@ > - Argument('unsigned', 'argc'), > - Argument('JS::Value*', 'vp')] > - assert descriptor.interface.hasInterfaceObject() > - assert NeedsGeneratedHasInstance(descriptor) > - CGAbstractStaticMethod.__init__(self, descriptor, HASINSTANCE_HOOK_NAME, I think you can remove HASINSTANCE_HOOK_NAME too. @@ +6734,5 @@ > if isConstructorRetval: > wrapArgs += ", desiredProto" > wrap = "%s(%s)" % (wrapMethod, wrapArgs) > + # Can only fail to wrap as a new-binding object > + # if they already threw an exception. Maybe rewrap this a bit?
Attachment #8964756 -
Flags: review?(peterv) → review+
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6d94022fef7a Remove hasXPConnectImpls support from bindings codegen. r=peterv
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/7271d56c190d followup. Actually address the review comments. r=peterv
Assignee | ||
Comment 5•6 years ago
|
||
I somehow managed to push without actually applying the changes.... :( Fixed now.
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6d94022fef7a https://hg.mozilla.org/mozilla-central/rev/7271d56c190d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•