OF currently uses TBPL's hidden jobs list to exclude jobs that are not visible in the default view: https://hg.mozilla.org/automation/orangefactor/file/aea03f25712e/server/builders.py Ideally we'd switch that to use the Treeherder equivalent (similar to bug 1085492), however unless bug 1085492 comes up with an approach we can steal (or to fix that bug, treeherder's API is tweaked), it's currently non-trivial to cross-reference the treeherder job names with those that TBPL currently uses for the hidden job list. Given that bug 870616 will likely mean a considerable rewrite of OF, it may just be easier to disable hidden job handling in OF short term, to at least stop OF's reliance on TBPL's getBuilders.php

OrangeFactor currently consumes TBPL's hidden job list, in order to exclude failures from jobs that are hidden. TBPL is going away and so we need to stop relying on it, however Treeherder's job names aren't compatible, and it's not worth spending the time creating a mapping, given that OrangeFactor v2 will consume all data from Treeherder directly, rather than partially from Elastic Search as at present - and so won't need to perform this mapping. It is also debatable whether we should hide failures from hidden jobs, since if someone went to the trouble to manually mark them in Treeherder/TBPL, even if the job was hidden, then we still likely care about the frequency.

Comment on attachment 8536242 [details] [diff] [review] Stop using TBPL's hidden jobs list Review of attachment 8536242 [details] [diff] [review]: ----------------------------------------------------------------- This also reminds me that we should update the license headers :) (depending on when OF will be replaced by TH).

[emorley@brasstacks1.dmz.scl3 ~]$ sudo -i [root@brasstacks1.dmz.scl3 ~]# su - webtools [webtools@brasstacks1.dmz.scl3 ~]$ cd ~/apps/orangefactor/src/orangefactor/ [webtools@brasstacks1.dmz.scl3 orangefactor]$ hg pull -u -v pulling from http://hg.mozilla.org/automation/orangefactor/ searching for changes all local heads known remotely adding changesets adding manifests adding file changes added 3 changesets with 3 changes to 3 files resolving manifests removing server/builders.py getting html/index.html getting server/handlers.py getting woo_mailer.conf.example 3 files updated, 0 files merged, 1 files removed, 0 files unresolved [root@brasstacks1.dmz.scl3 orangefactor]# /etc/init.d/orangefactor stop; /etc/init.d/orangefactor start stopping orangefactor [ OK ] starting orangefactorspawn-fcgi: child spawned successfully: PID: 3157 [ OK ] [root@brasstacks1.dmz.scl3 orangefactor]# /etc/init.d/nginx reload Reloading nginx: [ OK ]

(In reply to Mark Côté [:mcote] from comment #2) > This also reminds me that we should update the license headers :) (depending > on when OF will be replaced by TH). I've checked the other files and they seem fine - weirdly was just the one removed in this bug, that had the old style header.