Closed
Bug 1085730
Opened 10 years ago
Closed 10 years ago
OrangeFactor UI revisions should link to Treeherder instead of TBPL
Categories
(Tree Management Graveyard :: OrangeFactor, defect)
Tree Management Graveyard
OrangeFactor
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
mcote
:
review+
|
Details | Diff | Splinter Review |
https://hg.mozilla.org/automation/orangefactor/file/aea03f25712e/html/index.html#l217
Note the repo names are different to TBPL - they actually match the buildbot 'branch' (also the repo directory name) now. See the "name" property in:
https://github.com/mozilla/treeherder-service/blob/master/treeherder/model/fixtures/repository.json
|
Assignee | |
Comment 1•10 years ago
|
||
The branchnames used by OrangeFactor are in fact compatible with Treeherder, since they are actually the base repo names, not the TBPL customised names that many other tools used; so this straight-forwards substitution works :-)
Attachment #8536241 -
Flags: review?(mcote)
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → emorley
Status: NEW → ASSIGNED
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8536241 [details] [diff] [review]
Revisions in the UI should link to Treeherder instead of TBPL
Review of attachment 8536241 [details] [diff] [review]:
-----------------------------------------------------------------
I shall take your word that that URL is correct. :)
Attachment #8536241 -
Flags: review?(mcote) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Thanks :-)
I deployed this along with bug 1085728, though in the case of this bug, it turns out the code was unused after all - have filed bug 1111755 to clean it up.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 4•10 years ago
|
||
|
||
Updated•4 years ago
|
Product: Tree Management → Tree Management Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•