We need to enable PGO for 64-bit windows builds, but like we do for win32 builds.

This went back and forth a while ago, I thought we had it working in the recent past though: bug 692692.

And then disabled by bug 795748 and enabled again by bug 801386. And then disabled again, it seems.

As of today we're running opt, debug and PGO builds: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&jobname=WINNT%206.1%20x86-64.*build&rev=e08045200177 We're also running tests and talos for PGO builds: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&jobname=Windows%208%2064-bit.*pgo&rev=e08045200177 The PGO builds takes around 150mins (instead of 90mins). Can we assume that they're correct pgo builds? or should someone inspect the log or the build to verify it?

Looks good to me: https://tbpl.mozilla.org/php/getParsedLog.php?id=50951817&tree=Mozilla-Central&full=1 c:/builds/moz2_slave/m-cen-w32-pgo-0000000000000000/build/obj-firefox/_virtualenv/Scripts/python.exe c:/builds/moz2_slave/m-cen-w32-pgo-0000000000000000/build/config/link.py linker-vsize --uselist -- link -NOLOGO -DLL -OUT:xul.dll -PDB:xul.pdb -SUBSYSTEM:WINDOWS,5.01 -MACHINE:X86 StaticXULComponentsStart.obj nsDllMain.obj ./module.res -LARGEADDRESSAWARE -NXCOMPAT -RELEASE -DYNAMICBASE -SAFESEH -DEBUG -DEBUGTYPE:CV -DEBUG -OPT:REF -LTCG:PGUPDATE -DELAYLOAD:comdlg32.dll -DELAYLOAD:dbghelp.dll -DELAYLOAD:psapi.dll -DELAYLOAD:rasapi32.dll -DELAYLOAD:rasdlg.dll -DELAYLOAD:secur32.dll -DELAYLOAD:wininet.dll -DELAYLOAD:winspool.drv -DELAYLOAD:oleacc.dll -DELAYLOAD:msdmo.dll ../../media/kiss_fft/media_kiss_fft.lib ../../media/libstagefright/media_libstagefright.lib ../../security/certverifier/security_certverifier.lib ../../security/pkix/mozillapkix.lib ../../security/apps/security_apps.lib ../../xpcom/typelib/xpt/xpt.lib ../../xpcom/string/xpcom_string.lib ../../xpcom/base/xpcom_base.lib ../../xpcom/ds/xpcom_ds.lib ../../xpcom/io/xpcom_io.lib ../../xpcom/components/xpcom_components.lib ../../xpcom/threads/xpcom_threads.lib ../../xpcom/reflect/xptinfo/xpcom_reflect_xptinfo.lib ../../xpcom/reflect/xptcall/xpcom_reflect_xptcall.lib ../../xpcom/reflect/xptcall/md/win32/xpcom_reflect_xptcall_md_win32.lib ../../chrome/chrome.lib ../../xpcom/build/xpcom_build.lib ../../modules/libpref/modules_libpref.lib ../../intl/hyphenation/intl_hyphenation.lib ../../intl/locale/intl_locale.lib ../../intl/locale/windows/intl_locale_windows.lib ../../intl/lwbrk/intl_lwbrk.lib ../../intl/strres/intl_strres.lib ../../intl/unicharutil/intl_unicharutil.lib ../../intl/unicharutil/util/internal/intl_unicharutil_util_internal.lib ../../intl/uconv/intl_uconv.lib ../../intl/build/intl_build.lib ../../netwerk/base/src/netwerk_base_src.lib ../../netwerk/cookie/netwerk_cookie.lib ../../netwerk/dns/netwerk_dns.lib ../../netwerk/socket/netwerk_socket.lib ../../netwerk/mime/netwerk_mime.lib ../../netwerk/streamconv/src/netwerk_streamconv_src.lib ../../netwerk/streamconv/converters/netwerk_streamconv_converters.lib ../../netwerk/cache/netwerk_cache.lib ../../netwerk/cache2/netwerk_cache2.lib ../../netwerk/protocol/about/netwerk_protocol_about.lib ../../netwerk/protocol/app/netwerk_protocol_app.lib ../../netwerk/protocol/data/netwerk_protocol_data.lib ../../netwerk/protocol/device/netwerk_protocol_device.lib ../../netwerk/protocol/file/netwerk_protocol_file.lib ../../netwerk/protocol/ftp/netwerk_protocol_ftp.lib ../../netwerk/protocol/http/netwerk_protocol_http.lib ../../netwerk/protocol/res/netwerk_protocol_res.lib ../../netwerk/protocol/viewsource/netwerk_protocol_viewsource.lib ../../netwerk/protocol/websocket/netwerk_protocol_websocket.lib ../../netwerk/protocol/wyciwyg/netwerk_protocol_wyciwyg.lib ../../netwerk/system/win32/netwerk_system_win32.lib ../../netwerk/ipc/netwerk_ipc.lib ../../netwerk/srtp/src/nksrtp_s.lib ../../netwerk/sctp/src/nksctp_s.lib ../../netwerk/sctp/datachannel/netwerk_sctp_datachannel.lib ../../netwerk/wifi/netwerk_wifi.lib ../../netwerk/build/netwerk_build.lib ../../extensions/auth/extensions_auth.lib ../../ipc/chromium/ipc_chromium.lib ../../ipc/glue/ipc_glue.lib ../../ipc/ipdl/ipc_ipdl.lib ../../ipc/testshell/ipc_testshell.lib ../../js/ipc/js_ipc.lib ../../hal/hal.lib ../../js/xpconnect/wrappers/js_xpconnect_wrappers.lib ../../js/xpconnect/loader/js_xpconnect_loader.lib ../../js/xpconnect/src/js_xpconnect_src.lib ../../intl/chardet/intl_chardet.lib ../../media/libyuv/libyuv_libyuv/yuv.lib ../../modules/libjar/modules_libjar.lib ../../modules/libjar/zipwriter/modules_libjar_zipwriter.lib ../../storage/src/storage_src.lib ../../storage/build/storage_build.lib ../../extensions/cookie/extensions_cookie.lib ../../extensions/permissions/extensions_permissions.lib ../../rdf/base/rdf_base.lib ../../rdf/util/internal/rdf_util_internal.lib ../../rdf/datasource/rdf_datasource.lib ../../rdf/build/rdf_build.lib ../../media/webrtc/signaling/signaling_sipcc/sipcc.lib ../../media/webrtc/signaling/signaling_ecc/ecc.lib ../../media/mtransport/build/media_mtransport_build.lib ../../uriloader/base/uriloader_base.lib ../../uriloader/exthandler/uriloader_exthandler.lib ../../uriloader/prefetch/uriloader_prefetch.lib ../../caps/caps.lib ../../parser/xml/parser_xml.lib ../../parser/htmlparser/parser_htmlparser.lib ../../parser/html/parser_html.lib ../../gfx/2d/gfx_2d.lib ../../gfx/ycbcr/gfx_ycbcr.lib ../../gfx/src/gfx_src.lib ../../gfx/gl/gfx_gl.lib ../../gfx/layers/gfx_layers.lib ../../gfx/thebes/gfx_thebes.lib ../../gfx/ipc/gfx_ipc.lib ../../image/src/image_src.lib ../../image/decoders/image_decoders.lib ../../image/decoders/icon/win/image_decoders_icon_win.lib ../../image/decoders/icon/image_decoders_icon.lib ../../image/encoders/ico/image_encoders_ico.lib ../../image/encoders/png/image_encoders_png.lib ../../image/encoders/jpeg/image_encoders_jpeg.lib ../../image/encoders/bmp/image_encoders_bmp.lib ../../image/build/image_build.lib ../../dom/animation/dom_animation.lib ../../dom/apps/dom_apps.lib ../../dom/base/dom_base.lib ../../dom/activities/dom_activities.lib ../../dom/archivereader/dom_archivereader.lib ../../dom/bindings/dom_bindings.lib ../../dom/battery/dom_battery.lib ../../dom/browser-element/dom_browser-element.lib ../../dom/canvas/dom_canvas.lib ../../dom/cellbroadcast/dom_cellbroadcast.lib ../../dom/crypto/dom_crypto.lib ../../dom/alarm/dom_alarm.lib ../../dom/datastore/dom_datastore.lib ../../dom/devicestorage/dom_devicestorage.lib ../../dom/encoding/dom_encoding.lib ../../dom/events/dom_events.lib ../../dom/fetch/dom_fetch.lib ../../dom/filehandle/dom_filehandle.lib ../../dom/filesystem/dom_filesystem.lib ../../dom/geolocation/dom_geolocation.lib ../../dom/json/dom_json.lib ../../dom/jsurl/dom_jsurl.lib ../../dom/asmjscache/dom_asmjscache.lib ../../dom/mathml/dom_mathml.lib ../../dom/media/dom_media.lib ../../dom/media/bridge/dom_media_bridge.lib ../../dom/mobileconnection/dom_mobileconnection.lib ../../dom/notification/dom_notification.lib ../../dom/offline/dom_offline.lib ../../dom/power/dom_power.lib ../../dom/quota/dom_quota.lib ../../dom/storage/dom_storage.lib ../../dom/mobilemessage/dom_mobilemessage.lib ../../dom/time/dom_time.lib ../../dom/network/dom_network.lib ../../dom/plugins/base/dom_plugins_base.lib ../../dom/plugins/ipc/dom_plugins_ipc.lib ../../dom/indexedDB/dom_indexedDB.lib ../../dom/system/dom_system.lib ../../dom/system/windows/dom_system_windows.lib ../../dom/ipc/dom_ipc.lib ../../dom/workers/dom_workers.lib ../../dom/camera/dom_camera.lib ../../dom/audiochannel/dom_audiochannel.lib ../../dom/promise/dom_promise.lib ../../dom/smil/dom_smil.lib ../../dom/telephony/dom_telephony.lib ../../dom/voicemail/dom_voicemail.lib ../../dom/xbl/dom_xbl.lib ../../dom/xml/dom_xml.lib ../../dom/xslt/base/dom_xslt_base.lib ../../dom/xslt/xml/dom_xslt_xml.lib ../../dom/xslt/xpath/dom_xslt_xpath.lib ../../dom/xslt/xslt/dom_xslt_xslt.lib ../../dom/resourcestats/dom_resourcestats.lib ../../dom/gamepad/dom_gamepad.lib ../../view/view.lib ../../widget/widget.lib ../../widget/windows/widget_windows.lib ../../content/base/src/content_base_src.lib ../../content/html/content/src/content_html_content_src.lib ../../content/html/document/src/content_html_document_src.lib ../../content/media/content_media.lib ../../content/media/encoder/content_media_encoder.lib ../../content/media/gmp/content_media_gmp.lib ../../content/media/gmp/rlz/content_media_gmp_rlz.lib ../../content/media/mediasource/content_media_mediasource.lib ../../content/media/ogg/content_media_ogg.lib ../../content/media/systemservices/content_media_systemservices.lib ../../content/media/webaudio/content_media_webaudio.lib ../../content/media/webaudio/blink/content_media_webaudio_blink.lib ../../content/media/raw/content_media_raw.lib ../../content/media/wave/content_media_wave.lib ../../content/media/webm/content_media_webm.lib ../../content/media/directshow/content_media_directshow.lib ../../content/media/wmf/content_media_wmf.lib ../../content/media/fmp4/content_media_fmp4.lib ../../content/media/fmp4/wmf/content_media_fmp4_wmf.lib ../../content/media/fmp4/eme/content_media_fmp4_eme.lib ../../content/media/webrtc/content_media_webrtc.lib ../../content/media/webspeech/synth/content_media_webspeech_synth.lib ../../content/media/webspeech/recognition/content_media_webspeech_recognition.lib ../../content/media/imagecapture/content_media_imagecapture.lib ../../content/media/eme/content_media_eme.lib ../../content/svg/document/src/content_svg_document_src.lib ../../content/svg/content/src/content_svg_content_src.lib ../../content/xul/document/src/content_xul_document_src.lib ../../content/xul/content/src/content_xul_content_src.lib ../../content/xul/templates/src/content_xul_templates_src.lib ../../editor/txtsvc/editor_txtsvc.lib ../../editor/libeditor/editor_libeditor.lib ../../editor/txmgr/editor_txmgr.lib ../../editor/composer/editor_composer.lib ../../layout/style/layout_style.lib ../../layout/base/layout_base.lib ../../layout/generic/layout_generic.lib ../../layout/forms/layout_forms.lib ../../layout/tables/layout_tables.lib ../../layout/svg/layout_svg.lib ../../layout/xul/layout_xul.lib ../../layout/xul/tree/layout_xul_tree.lib ../../layout/xul/grid/layout_xul_grid.lib ../../layout/ipc/layout_ipc.lib ../../layout/mathml/layout_mathml.lib ../../layout/inspector/layout_inspector.lib ../../layout/printing/layout_printing.lib ../../layout/build/layout_build.lib ../../layout/media/webrtc/webrtc.lib ../../docshell/base/docshell_base.lib ../../docshell/shistory/src/docshell_shistory_src.lib ../../docshell/build/docshell_build.lib ../../embedding/components/windowwatcher/embedding_components_windowwatcher.lib ../../embedding/components/appstartup/embedding_components_appstartup.lib ../../embedding/components/find/embedding_components_find.lib ../../embedding/components/webbrowserpersist/embedding_components_webbrowserpersist.lib ../../embedding/components/commandhandler/embedding_components_commandhandler.lib ../../embedding/components/printingui/win/embedding_components_printingui_win.lib ../../embedding/components/build/embedding_components_build.lib ../../embedding/browser/embedding_browser.lib ../../embedding/browser/build/embedding_browser_build.lib ../../xpfe/appshell/xpfe_appshell.lib ../../extensions/universalchardet/src/base/extensions_universalchardet_src_base.lib ../../extensions/universalchardet/src/xpcom/extensions_universalchardet_src_xpcom.lib ../../accessible/windows/msaa/accessible_windows_msaa.lib ../../accessible/windows/ia2/accessible_windows_ia2.lib ../../accessible/windows/sdn/accessible_windows_sdn.lib ../../accessible/windows/uia/accessible_windows_uia.lib ../../accessible/base/accessible_base.lib ../../accessible/generic/accessible_generic.lib ../../accessible/html/accessible_html.lib ../../accessible/ipc/accessible_ipc.lib ../../accessible/xpcom/accessible_xpcom.lib ../../accessible/xul/accessible_xul.lib ../../tools/profiler/tools_profiler.lib ../../xpfe/components/windowds/xpfe_components_windowds.lib ../../xpfe/components/directory/xpfe_components_directory.lib ../../xpfe/components/build/xpfe_components_build.lib ../../extensions/spellcheck/hunspell/src/extensions_spellcheck_hunspell_src.lib ../../extensions/spellcheck/src/extensions_spellcheck_src.lib ../../security/manager/boot/src/security_manager_boot_src.lib ../../security/manager/ssl/src/security_manager_ssl_src.lib ../../security/manager/pki/src/security_manager_pki_src.lib ../../toolkit/components/alerts/toolkit_components_alerts.lib ../../toolkit/components/commandlines/toolkit_components_commandlines.lib ../../toolkit/components/diskspacewatcher/toolkit_components_diskspacewatcher.lib ../../toolkit/components/downloads/toolkit_components_downloads.lib ../../toolkit/components/filewatcher/toolkit_components_filewatcher.lib ../../toolkit/components/finalizationwitness/toolkit_components_finalizationwitness.lib ../../toolkit/components/find/toolkit_components_find.lib ../../toolkit/components/jsdownloads/src/toolkit_components_jsdownloads_src.lib ../../toolkit/components/mediasniffer/toolkit_components_mediasniffer.lib ../../toolkit/components/osfile/toolkit_components_osfile.lib ../../toolkit/components/parentalcontrols/toolkit_components_parentalcontrols.lib ../../toolkit/components/perf/toolkit_components_perf.lib ../../toolkit/components/places/toolkit_components_places.lib ../../toolkit/components/protobuf/toolkit_components_protobuf.lib ../../toolkit/components/reflect/toolkit_components_reflect.lib ../../toolkit/components/startup/toolkit_components_startup.lib ../../toolkit/components/statusfilter/toolkit_components_statusfilter.lib ../../toolkit/components/telemetry/toolkit_components_telemetry.lib ../../toolkit/components/terminator/toolkit_components_terminator.lib ../../toolkit/components/typeaheadfind/toolkit_components_typeaheadfind.lib ../../toolkit/components/workerlz4/toolkit_components_workerlz4.lib ../../toolkit/components/ctypes/toolkit_components_ctypes.lib ../../toolkit/components/autocomplete/toolkit_components_autocomplete.lib ../../toolkit/components/satchel/toolkit_components_satchel.lib ../../toolkit/components/url-classifier/toolkit_components_url-classifier.lib ../../toolkit/components/build/toolkit_components_build.lib ../../toolkit/devtools/security/toolkit_devtools_security.lib ../../toolkit/devtools/server/toolkit_devtools_server.lib ../../toolkit/identity/toolkit_identity.lib ../../toolkit/mozapps/extensions/toolkit_mozapps_extensions.lib ../../toolkit/profile/toolkit_profile.lib ../../toolkit/mozapps/update/common/updatecommon.lib ../../toolkit/xre/toolkit_xre.lib ../../toolkit/system/windowsproxy/toolkit_system_windowsproxy.lib ../../toolkit/crashreporter/toolkit_crashreporter.lib ../../toolkit/crashreporter/google-breakpad/src/common/breakpad_common_s.lib ../../toolkit/crashreporter/google-breakpad/src/processor/toolkit_crashreporter_google-breakpad_src_processor.lib ../../toolkit/crashreporter/breakpad-windows-libxul/google_breakpad_libxul_s.lib ../../extensions/pref/autoconfig/src/extensions_pref_autoconfig_src.lib ../../services/crypto/component/services_crypto_component.lib ../../startupcache/startupcache.lib ../../js/ductwork/debugger/js_ductwork_debugger.lib ../../other-licenses/snappy/other-licenses_snappy.lib ../../js/src/js_static.lib ../../layout/media/gkmedias.lib ../../config/external/nspr/nspr.lib ../../config/external/sqlite/sqlite.lib ../../config/external/zlib/zlib.lib ../../config/external/icu/icu.lib ../../toolkit/library/StaticXULComponentsEnd/StaticXULComponentsEnd.lib ../../config/external/nss/nss3.lib ../../intl/icu/target/lib/icuin.lib ../../intl/icu/target/lib/icuuc.lib ../../intl/icu/target/lib/icudt.lib ../../security/sandbox/win/src/sandboxbroker/sandboxbroker.lib ../../memory/mozalloc/mozalloc.lib -LIBPATH:../../dist/lib -NODEFAULTLIB:msvcrt -NODEFAULTLIB:msvcprt -DEFAULTLIB:mozcrt kernel32.lib user32.lib gdi32.lib winmm.lib wsock32.lib advapi32.lib secur32.lib netapi32.lib psapi.lib shell32.lib dbghelp.lib usp10.lib ole32.lib msimg32.lib winmm.lib secur32.lib crypt32.lib iphlpapi.lib strmiids.lib dmoguids.lib wmcodecdspuuid.lib amstrmid.lib msdmo.lib wininet.lib mfuuid.lib version.lib winspool.lib comdlg32.lib imm32.lib shlwapi.lib ws2_32.lib rasapi32.lib rasdlg.lib uxtheme.lib setupapi.lib sensorsapi.lib portabledeviceguids.lib windowscodecs.lib wbemuuid.lib wintrust.lib wtsapi32.lib oleacc.lib oleaut32.lib delayimp.lib mozmake.exe[6]: Entering directory 'c:/builds/moz2_slave/m-cen-w32-pgo-0000000000000000/build/obj-firefox/js/src/gdb' mozmake.exe[6]: Nothing to be done for 'target'. mozmake.exe[6]: Leaving directory 'c:/builds/moz2_slave/m-cen-w32-pgo-0000000000000000/build/obj-firefox/js/src/gdb' mozmake.exe[6]: Entering directory 'c:/builds/moz2_slave/m-cen-w32-pgo-0000000000000000/build/obj-firefox/js/src/jsapi-tests' mozmake.exe[6]: Nothing to be done for 'target'. mozmake.exe[6]: Leaving directory 'c:/builds/moz2_slave/m-cen-w32-pgo-0000000000000000/build/obj-firefox/js/src/jsapi-tests' TinderboxPrint: linker max vsize: 4294967295 PGOMGR : warning PG0188: No .PGC files matching 'xul!*.pgc' were found. Reading PGD file 1: xul.pgd Creating library xul.lib and object xul.exp Generating code 0 of 0 ( 0.0%) original invalid call sites were matched. 0 new call sites were added. 350 of 285499 ( 0.12%) profiled functions will be compiled for speed, and the rest of the functions will be compiled for size c:\builds\moz2_slave\m-cen-w32-pgo-0000000000000000\build\gfx\qcms\transform_util.c(134) : warning C4756: overflow in constant arithmetic c:\builds\moz2_slave\m-cen-w32-pgo-0000000000000000\build\gfx\qcms\transform_util.c(170) : warning C4756: overflow in constant arithmetic c:\builds\moz2_slave\m-cen-w32-pgo-0000000000000000\build\gfx\qcms\transform_util.c(134) : warning C4756: overflow in constant arithmetic c:\builds\moz2_slave\m-cen-w32-pgo-0000000000000000\build\gfx\cairo\cairo\src\cairo.c(2811) : warning C4756: overflow in constant arithmetic c:\builds\moz2_slave\m-cen-w32-pgo-0000000000000000\build\gfx\cairo\cairo\src\cairo.c(2812) : warning C4756: overflow in constant arithmetic c:\builds\moz2_slave\m-cen-w32-pgo-0000000000000000\build\gfx\cairo\cairo\src\cairo.c(2813) : warning C4756: overflow in constant arithmetic c:\builds\moz2_slave\m-cen-w32-pgo-0000000000000000\build\gfx\cairo\cairo\src\cairo.c(2814) : warning C4756: overflow in constant arithmetic c:\builds\moz2_slave\m-cen-w32-pgo-0000000000000000\build\js\src\jscntxt.cpp(855) : warning C4700: uninitialized local variable 'dummy' used 701617 of 2334501 inline instances were from dead/cold paths 285489 of 285499 functions (100.0%) were optimized using profile data, and the rest of the functions were optimized without using profile data 18232350037 of 18232350037 instructions (100.0%) were optimized using profile data, and the rest of the instructions were optimized without using profile data Finished generating code

Resolved fixed?

sure!