Closed
Bug 1088408
Opened 10 years ago
Closed 10 years ago
[Calendar] Can't open settings tray
Categories
(Firefox OS Graveyard :: Gaia::Calendar, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S7 (24Oct)
People
(Reporter: kgrandon, Assigned: kgrandon)
References
Details
(Whiteboard: [systemsfe])
Attachments
(1 file)
I am no longer able to open the settings tray in my calendar. I am seeing the following dump which looks interesting:
I/Calendar( 1964): Content JS LOG: views/settings [calendar] "Will render settings view."
I/Calendar( 1964): at module.exports/< (app://calendar.gaiamobile.org/gaia_build_defer_index.js:762:259)
I/Calendar( 1964): Content JS LOG: views/settings [calendar] "Inject calendars into settings list."
I/Calendar( 1964): at module.exports/< (app://calendar.gaiamobile.org/gaia_build_defer_index.js:762:259)
I/Calendar( 1964): Content JS LOG: views/settings [calendar] "Will add object to settings view" "2" {"error":{"name":"authentication","date":"2014-10-23T18:47:04.036Z"},"remote":{"id":"/dav/kgrandon@mozilla.com/Calendar/","url":"/dav/kgrandon@mozilla.com/Calendar/","name":"Calendar","color":"#00aacc","description":"Kevin Grandon's Calendar","syncToken":"361752-367934","privilegeSet":["read-current-user-privilege-set","read","write","write-content","write-properties","bind","unbind"]},"accountId":1,"localDisplayed":true,"lastEventSyncDate":"2014-10-06T20:04:19.659Z","lastEventSyncToken":"361752-367934","firstEventSyncDate":"2014-07-10T07:00:00.000Z","_id":2}
I/Calendar( 1964): at module.exports/< (app://calendar.gaiamobile.org/gaia_build_defer_index.js:762:259)
E/Calendar( 1964): Content JS ERROR: Views.Settings error: [object Object]
E/Calendar( 1964): at Settings.prototype.render/< (app://calendar.gaiamobile.org/js/views/settings.js:888:8)
E/Calendar( 1964): at exports.map/< (app://calendar.gaiamobile.org/js/views/settings.js:425:17)
E/Calendar( 1964): at forEach (self-hosted:201:12)
E/Calendar( 1964): at exports.map (app://calendar.gaiamobile.org/js/views/settings.js:423:2)
E/Calendar( 1964): at exports.forEach (app://calendar.gaiamobile.org/js/views/settings.js:418:2)
E/Calendar( 1964): at Settings.prototype.render (app://calendar.gaiamobile.org/js/views/settings.js:882:0)
E/Calendar( 1964): at View.prototype.onactive (app://calendar.gaiamobile.org/js/views/time_header.js:225:6)
E/Calendar( 1964): at Settings.prototype.onactive/< (app://calendar.gaiamobile.org/js/views/settings.js:987:6)
E/Calendar( 1964): Content JS ERROR: Error fetching calendars in View.Settings TypeError: el is undefined
E/Calendar( 1964): at Settings.prototype.onactive/< (app://calendar.gaiamobile.org/js/views/settings.js:1017:13)
Assignee | ||
Comment 1•10 years ago
|
||
Turns out to be a wrong index lookup on the element.
Assignee | ||
Comment 2•10 years ago
|
||
Seems to be a regression from bug 1027707.
Blocks: 1027707
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8510740 [details]
Github pull request
Gareth - could you review this? We should already have a test for this here: https://github.com/mozilla-b2g/gaia/blob/master/apps/calendar/test/unit/views/settings_test.js#L487
I'm trying to figure out why this didn't catch it.
Attachment #8510740 -
Flags: review?(gaye)
Assignee | ||
Comment 4•10 years ago
|
||
Hmm, it seems none of the unit tests in settings_test have been getting run =/ Need to figure this out, but it should be another bug I suppose.
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8510740 [details]
Github pull request
Miller - could you review this?
Attachment #8510740 -
Flags: review?(miller)
Comment 6•10 years ago
|
||
Comment on attachment 8510740 [details]
Github pull request
LGTM! we can re-enable the unit tests later.
Attachment #8510740 -
Flags: review?(miller)
Attachment #8510740 -
Flags: review?(gaye)
Attachment #8510740 -
Flags: review+
Assignee | ||
Comment 7•10 years ago
|
||
(In reply to Miller Medeiros [:millermedeiros] from comment #6)
> Comment on attachment 8510740 [details]
> Github pull request
>
> LGTM! we can re-enable the unit tests later.
Thanks. I've filed bug 1088810 for this, and will look when I get time unless you guys beat me to it.
Assignee | ||
Comment 8•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → kgrandon
Whiteboard: [systemsfe]
Target Milestone: --- → 2.1 S7 (24Oct)
Comment 9•10 years ago
|
||
Thanks for the patch Kevin! Let's try this week to get that test running again also..
You need to log in
before you can comment on or make changes to this bug.
Description
•