any further details about this?

I don't know who's best to review social API styles, so feel free to cancel review if this isn't your domain. -- This patch : - Moves all CSS into shared/ - Restyles the buttons to match the australis subview buttons - Removes the background from the panels so the panel style automatically fits the platform.

Ideally, I'd like to update CSS here : https://activations.cdn.mozilla.net/en-US/sharePanel.html as well.

(In reply to Tim Nguyen [:ntim] from comment #3) > Ideally, I'd like to update CSS here : > https://activations.cdn.mozilla.net/en-US/sharePanel.html as well. I need to move that into the mozilla group on github....but you can modify and do a pull request here: https://github.com/mixedpuppy/socialapi-directory

(In reply to Shane Caraveo (:mixedpuppy) from comment #4) > I need to move that into the mozilla group on github.... I filed bug 1097231 for this.

Comment on attachment 8520603 [details] [diff] [review] Patch Review of attachment 8520603 [details] [diff] [review]: ----------------------------------------------------------------- This looks like something Shane should review.

Comment on attachment 8520603 [details] [diff] [review] Patch Review of attachment 8520603 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, but the question below is puzzling. ::: browser/themes/windows/browser.css @@ -1634,5 @@ > -#social-share-panel { > - max-height: 600px; > - min-height: 100px; > - max-width: 800px; > - min-width: 300px; Your patch moves this from windows/browser.css to the shared file but left a copy of it in osx/browser.css. Oddly enough, they were never defined for Linux. I'm guessing Linux is/has-been broken or not styled up to this point. Shane, did you know about this?

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #7) > Comment on attachment 8520603 [details] [diff] [review] > Patch > > Review of attachment 8520603 [details] [diff] [review]: > ----------------------------------------------------------------- > > Looks good, but the question below is puzzling. > > ::: browser/themes/windows/browser.css > @@ -1634,5 @@ > > -#social-share-panel { > > - max-height: 600px; > > - min-height: 100px; > > - max-width: 800px; > > - min-width: 300px; > > Your patch moves this from windows/browser.css to the shared file but left a > copy of it in osx/browser.css. Oddly enough, they were never defined for > Linux. I'm guessing Linux is/has-been broken or not styled up to this point. > Shane, did you know about this? Linux is working fine. I don't recall the specific reason I put min/max sizes on osx, but I don't think it is necessary.

Comment on attachment 8520603 [details] [diff] [review] Patch .social-panel-frame isn't the only child in the panel, #social-share-provider-buttons is also in there, thus the need to tweak the border radius to be sure the panel border radius appears correctly. This should only be important on osx.

btw, in bug 1075251 I've linked to a change I've done to the panel.

Tim, can you please post a screenshot of the changes you have made?

Pull request on github : https://github.com/mixedpuppy/socialapi-directory/pull/3 (In reply to Sevaan Franks [:sevaan] from comment #11) > Tim, can you please post a screenshot of the changes you have made? I'll post it as soon as I can.

There you go.

Any chance you can review my PR from comment #12 any time soon ?

(In reply to Tim Nguyen [:ntim] from comment #14) > Any chance you can review my PR from comment #12 any time soon ? merged.

(In reply to Shane Caraveo (:mixedpuppy) from comment #15) > (In reply to Tim Nguyen [:ntim] from comment #14) > > Any chance you can review my PR from comment #12 any time soon ? > > merged. You can see the various updates to the panel here: https://activations.paas.allizom.org/en-US/sharePanel.html

There are more tweaks I'd like to make, but I probably won't have time to make them.