Closed
Bug 1091107
Opened 10 years ago
Closed 10 years ago
Visual refinements in the tab strip
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox36 fixed)
RESOLVED
FIXED
Firefox 36
Tracking | Status | |
---|---|---|
firefox36 | --- | fixed |
People
(Reporter: lucasr, Assigned: lucasr)
References
Details
(Whiteboard: [leave open])
Attachments
(2 files)
No description provided.
Comment 1•10 years ago
|
||
Before I get a pretty picture... Top padding: 8dp Tab size: 40 dp Font: 14sp Roboto, Light #777777
Assignee | ||
Comment 2•10 years ago
|
||
For reference: https://bug1066253.bugzilla.mozilla.org/attachment.cgi?id=8493280
Comment 3•10 years ago
|
||
Adding a note to clean up some of the numbers here, esp around tab overflow situations.
Assignee | ||
Comment 4•10 years ago
|
||
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8513834 [details] [diff] [review] Visual refinements in the tab strip (r=mcomella) Tweaked the specs to better snap to an 8dp grid.
Attachment #8513834 -
Flags: review?(michael.l.comella)
Assignee | ||
Comment 6•10 years ago
|
||
Here's how it looks. I'll tweak the title font in a separate patch.
Attachment #8513836 -
Flags: feedback?(alam)
Comment 7•10 years ago
|
||
Comment on attachment 8513836 [details]
Screenshot
Looking better!
separate issues to note: magnifying glass, and font (which you already mentioned :)
Attachment #8513836 -
Flags: feedback?(alam) → feedback+
Comment 8•10 years ago
|
||
Comment on attachment 8513834 [details] [diff] [review] Visual refinements in the tab strip (r=mcomella) Review of attachment 8513834 [details] [diff] [review]: ----------------------------------------------------------------- (In reply to Lucas Rocha (:lucasr) from comment #5) > Tweaked the specs to better snap to an 8dp grid. This is in opposition to the spec in comment 2 - is this okay? (In reply to Anthony Lam (:antlam) from comment #7) > separate issues to note: magnifying glass If you mean it's blurry, it should be fixed by bug 1077032.
Attachment #8513834 -
Flags: review?(michael.l.comella) → review+
Assignee | ||
Comment 9•10 years ago
|
||
(In reply to Michael Comella (:mcomella) from comment #8) > Comment on attachment 8513834 [details] [diff] [review] > Visual refinements in the tab strip (r=mcomella) > > Review of attachment 8513834 [details] [diff] [review]: > ----------------------------------------------------------------- > > (In reply to Lucas Rocha (:lucasr) from comment #5) > > Tweaked the specs to better snap to an 8dp grid. > > This is in opposition to the spec in comment 2 - is this okay? As long as antlam approves the final result, that's fine :-)
Assignee | ||
Comment 10•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/5a85c6a1757b
Whiteboard: [leave open]
Assignee | ||
Comment 12•10 years ago
|
||
Discussed the font changes with antlam, decided to stick with regular type on tab strip items. Closing.
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox36:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•