Closed
Bug 1091901
Opened 10 years ago
Closed 10 years ago
Tracking Protection: no HiDPI friendly icon in preferences
Categories
(Firefox :: Theme, defect)
Tracking
()
People
(Reporter: soeren.hentzschel, Assigned: Gavin)
References
Details
Attachments
(2 files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
screenshot
The shield icon in the preferences for the tracking protection is not HiDPI friendly.
|
||
Comment 1•10 years ago
|
||
The assets are there ( chrome://browser/skin/bad-content-blocked-16@2x.png resolves in current OS X nightly), but they'd be tricky to apply in the current chrome structure, considering they're hardcoded in the XUL...
Flags: qe-verify-
Flags: firefox-backlog+
|
Assignee | |
Comment 2•10 years ago
|
||
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #8515682 -
Flags: review?(gijskruitbosch+bugs)
|
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8515682 [details] [diff] [review]
patch
Review of attachment 8515682 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/themes/shared/incontentprefs/preferences.css
@@ +296,5 @@
> }
>
> +#trackingProtectionImage {
> + width: 16px;
> + height: 16px;
Nit: do you really need to set both the height/width? I would have assumed either would have sufficed.
Attachment #8515682 -
Flags: review?(gijskruitbosch+bugs) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
Target Milestone: --- → Firefox 36
|
|
Assignee | |
Comment 5•10 years ago
|
||
(In reply to :Gijs Kruitbosch from comment #3)
> Nit: do you really need to set both the height/width? I would have assumed
> either would have sufficed.
Perhaps not, but it seems confusing/pointless to only set one, so I left this as-is.
|
||
Comment 6•10 years ago
|
||
The rule is set in shared file. On Windows, when scale is set to 200%, there would be no icon shown because it is only shipped on OS X.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
Iteration: --- → 36.2
You need to log in
before you can comment on or make changes to this bug.
Description
•