Closed Bug 1104730 Opened 10 years ago Closed 10 years ago

Tracking Protection: no icon in preferences when using 2dppi on non-OSX

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Platform:
All
Windows 8.1
Type:
defect
Priority:
Not set
Severity:
normal
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 37
Iteration:
37.1
Tracking Flags:
Tracking Status
firefox36 --- affected
firefox37 --- affected

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

Attachments

(2 files, 2 obsolete files)

Patch v2
(deleted), patch
jaws
: review+
Details | Diff | Splinter Review
MozReview Request: Bug 1104730 - ship bad-content-16@2x on Linux/Windows, r=jaws
(deleted), text/x-review-board-request
Details
+++ This bug was initially created as a clone of Bug #1091901 +++ The shield icon in the preferences for the tracking protection is now HiDPI friendly, but is applied in CSS that's shared, while the icon is only shipped on OS X. I should have caught this in review on bug 1091901. :-(
Iteration: 36.2 → ---
Points: --- → 1
Flags: qe-verify-
Flags: in-testsuite-
Flags: firefox-backlog+
Attached patch ship bad-content-16@2x on Linux/Windows, (obsolete) (deleted) — — Splinter Review
Seems the other in-content stuff does hidpi on linux/windows as well, so this probably should, too.
Attachment #8528358 - Flags: review?(jaws)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Comment on attachment 8528358 [details] [diff] [review] ship bad-content-16@2x on Linux/Windows, Except that the file doesn't exist...
Attachment #8528358 - Attachment is obsolete: true
Attachment #8528358 - Flags: review?(jaws)
Iteration: --- → 37.1
Attached patch Patch v2 (deleted) — — Splinter Review
Just moved all the images to shared/ considering they're the same anyway. Used the Windows ones where available because they've been optimized by bug 1062969.
Comment on attachment 8528378 [details] [diff] [review] Patch v2 Review of attachment 8528378 [details] [diff] [review]: ----------------------------------------------------------------- Note that splinter doesn't get the hg moves/renames right, apparently. :-\
Attachment #8528378 - Flags: review?(jaws)
Comment on attachment 8528378 [details] [diff] [review] Patch v2 Review of attachment 8528378 [details] [diff] [review]: ----------------------------------------------------------------- I looked at the patch file directly to see the hg moves/renames. Yeah, it would be nice if Splinter handled it better. Do you know if ReviewBoard does this right? If not, we should probably get a bug on file for either Splinter or Review Board (or both!) :)
Attachment #8528378 - Flags: review?(jaws) → review+
status-firefox36: --- → affected
status-firefox37: --- → affected
Attached file MozReview Request: bz://1104730/Gijs (obsolete) (deleted) —
/r/1139 - Bug 1104730 - ship bad-content-16@2x on Linux/Windows, r=jaws Pull down this commit: hg pull review -r 4a388c2d87c516319bb0ca2b4169b6de88f2ed8f
(In reply to :Gijs Kruitbosch from comment #8) > /r/1139 - Bug 1104730 - ship bad-content-16@2x on Linux/Windows, r=jaws > > Pull down this commit: > > hg pull review -r 4a388c2d87c516319bb0ca2b4169b6de88f2ed8f So this is the reviewboard alternative. It doesn't make stuff up, but it does fail at indicating *any* renames, that I can see. :-\
https://hg.mozilla.org/mozilla-central/rev/4a388c2d87c5
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Attachment #8532080 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: