Looking to increase the hit target of the collapse button in a group with affecting the visuals. I've attached the page from the spec but it can also be found here: https://bugzilla.mozilla.org/show_bug.cgi?id=1086514

The hit-target for the element in question is already 3rem, unfortunately: https://github.com/mozilla-b2g/gaia/blob/master/shared/elements/gaia_grid/style.css#L216 I remember finding that a 2rem height hit-target made it basically impossible to hit altogether.

new spec from Hung, to increase touch target of expand/collapse button

reopening with updating spec to increase touch target to 4 rem. (see Hung's latest spec attached).

Ni'ing Chris just to check in on the status of this...

Comment on attachment 8559247 [details] [PullReq] Cwiiis:bug1093270-increase-group-header-hit-target to mozilla-b2g:master Just CSS changes, seems to work.

Comment on attachment 8559247 [details] [PullReq] Cwiiis:bug1093270-increase-group-header-hit-target to mozilla-b2g:master Looks good to me, thanks!

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/d9bbbbb901448684b93205524f979a7646e362ae

Come on, this is clearly not a bug that should block release :p As it's a small change, I'm sure uplift will be no problem. Let's let it sit for a couple of days to make sure there's nothing obvious wrong.

Comment on attachment 8559247 [details] [PullReq] Cwiiis:bug1093270-increase-group-header-hit-target to mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): [User impact] if declined: Can be hard to hit expand/collapse arrow [Testing completed]: Tested manually and been on master for a week [Risk to taking this patch] (and alternatives if risky): Low risk of performance degradation due to z-index changes (but I've not noticed any) [String changes made]: None

(In reply to Chris Lord [:cwiiis] from comment #10) > Comment on attachment 8559247 [details] > [PullReq] Cwiiis:bug1093270-increase-group-header-hit-target to > mozilla-b2g:master > > [Approval Request Comment] > [Bug caused by] (feature/regressing bug #): > [User impact] if declined: Can be hard to hit expand/collapse arrow > [Testing completed]: Tested manually and been on master for a week > [Risk to taking this patch] (and alternatives if risky): Low risk of > performance degradation due to z-index changes (but I've not noticed any) PLease do keep an eye on any perf regressions that may fallout here. Thanks! > [String changes made]: None

v2.2: https://github.com/mozilla-b2g/gaia/commit/d205e24d6dae5f227baf57f9956cb1fc90d91e06

This issue is verified fixed on Flame 3.0 The hit boxes for the collapse and expand group icons on the homescreen have been increased in size to properly reflect what is seen in the UX spec sheet. Environmental Variables: Device: Flame 3.0 (319mb)(Kitkat)(Full Flash) Build ID: 20150211010216 Gaia: 8c7865486a1b11076b849bbf8f7fccbaffbfafe7 Gecko: ee093ca70666 Gonk: e7c90613521145db090dd24147afd5ceb5703190 Version: 38.0a1 (3.0) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0 ------------------------------------------------------------------------------------------------------------- adding verify me keyword for this issue to be verified on 2.2

This issue has been verified successfully on latest Flame2.2 Verify picture:"verify.jpg". **You can see the "collapse button" size on Flame 2.2 is the same as that in “collapse_hittarget.png” of Comment 0. Flame 2.2 build: Build ID 20150211002505 Gaia Revision 943be6fd146017dcd9d4c9d1027be1e43bad13eb Gaia Date 2015-02-11 08:01:09 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/e614443583e7 Gecko Version 37.0a2 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150211.040242 Firmware Date Wed Feb 11 04:02:53 EST 2015 Bootloader L1TC000118D0