Closed
Bug 1095583
Opened 10 years ago
Closed 10 years ago
assert.throws should catch thrown strings
Categories
(Add-on SDK Graveyard :: General, defect)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: evold, Assigned: evold)
References
Details
Attachments
(1 file)
When working on bug I discovered that when a piece of code does throws a strong like so `throw "this is an error"` then the assert.throws code fails to test the comparison string/regexp against the expected "this is an error" string and it actually tests against a blank string, "".
|
Assignee | |
Comment 1•10 years ago
|
||
(In reply to Erik Vold [:erikvold] (please needinfo? me) from comment #0) > When working on bug I discovered that when a piece of code does throws a > strong like so `throw "this is an error"` then the assert.throws code fails > to test the comparison string/regexp against the expected "this is an error" > string and it actually tests against a blank string, "". * When working on bug 1092882
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → evold
Summary: assert.throws should catch thrown strongs → assert.throws should catch thrown strings
|
||
Updated•10 years ago
|
Attachment #8519265 -
Flags: review?(jsantell) → review+
|
||
Comment 3•10 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/412eb8742666cae1f641bea93fa130a6f5233152 Bug 1095583 - assert.throws should catch thrown strings https://github.com/mozilla/addon-sdk/commit/384c2d6bd53b86af98bcd0e151452bb1012894ce Merge pull request #1705 from erikvold/1095583 Bug 1095583 - assert.throws should catch thrown strings r=@jsantell
|
|
Assignee | |
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•