p_mccarthy Reporter
	Description • 10 years ago

User Agent: Mozilla/5.0 (Windows NT 5.2; Win64; x64; rv:36.0) Gecko/20100101 Firefox/36.0
Build ID: 20141111030203

Steps to reproduce:

download button should invoke adobe acrobat or acrobat viewer


Actual results:

bar claims acrobat viewer isn't installed


Expected results:

should have invoked existing acrobat or acrobat viewer

	:Gijs (he/him)
	Comment 1 • 10 years ago

If you go into the preferences, on the general tab, is e10s enabled? If it is, does this work correctly with e10s disabled?

If that isn't the issue, can you try to find a regression window using mozregression? ( http://mozilla.github.io/mozregression/ )

	p_mccarthy Reporter
	Comment 2 • 10 years ago

Everything works if I disable e10s

	Brendan Dahl [:bdahl]
	Comment 3 • 10 years ago

The download button seems to work fine, do you mean the "Open with a different viewer" button?

	Yury Delendik (:yury)
	Comment 4 • 10 years ago

We see in the browser cosole: "NS_ERROR_NOT_AVAILABLE: Async version must be used". It's probably related.

	Chris Peterson [:cpeterson]
	Comment 5 • 10 years ago

I can reproduce this bug with Nightly 36. Firefox auto-downloads PDF links instead of displaying them with the built-in PDF Viewer:

http://www.irs.gov/pub/irs-pdf/fw4.pdf

	Chris Peterson [:cpeterson]
	Comment 6 • 10 years ago

I am using PDF Viewer 1.0.277.

	Yury Delendik (:yury)
	Comment 7 • 10 years ago

The add-on at amo is not e10s compatible -- please uninstall

	Jorge Villalobos [:jorgev] (he/him)
	Comment 8 • 10 years ago

Are there plans to update the AMO version?

	Yury Delendik (:yury)
	Comment 9 • 10 years ago

(In reply to Jorge Villalobos [:jorgev] from comment #8)
> Are there plans to update the AMO version?

Updating of the AMO extension is not a priority, and we are trying to eventually disable it. It adds burden of supporting out-of-date inefficient APIs in the chrome code (recent example bug 1069953)

Please notice that the comments 5-8 are not related to the main issue (see STR in comment 0) and shall be placed in a new bug related to pdf.js AMO extension, and not built-in PDF Viewer.

	Terrell Kelley
	Comment 10 • 9 years ago

What would be the use case of keeping the AMO extension instead of just using the built in replacement?

	Arash
	Comment 11 • 8 years ago

I just tested with a random pdf[1] I found and this works fine. Tested on:
* 46.0a2 (2016-03-07), Linux Ubuntu
* 47.0a2 (2016-03-11), OS X 10.11.3

It's probably save to mark this as resolved.

[1] http://www.pdf995.com/samples/pdf.pdf

	Jonas Jenwald [:Snuffleupagus]
	Comment 12 • 8 years ago

(In reply to Arash from comment #11)
> It's probably save to mark this as resolved.

This is *not* fixed, since the problem, as mentioned in comment 3, still exists.
The "Open With Different Viewer" button on the Fallback bar still doesn't work with e10s *enabled*, and it fails with (in the Browser Console):
> TypeError: frontWindow is null

The error originates here: https://github.com/mozilla/pdf.js/blob/41efb92d3a6af0be38afaf27808504e404491afd/extensions/firefox/content/PdfStreamConverter.jsm#L326.

Note: For testing, the Fallback bar can be triggered manually for any PDF document. After opening a PDF document, press <Ctrl>+<Shift>+<K> and run the following in the console:
> PDFViewerApplication.fallback()
This will display the Fallback bar, and clicking on its button fails in e10s.

	Yury Delendik (:yury)
	Comment 13 • 8 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4bd33654b0cd

	Yury Delendik (:yury)
	Comment 14 • 8 years ago

Comment on attachment 8734120 [details] [diff] [review]
Allow nsIDOMWindow as aContentContext the nsExternalHelperAppService::DoContent.

Bad solution due to bug 1241764