Closed
Bug 1099146
Opened 10 years ago
Closed 10 years ago
Use Angular one-time binding for the treestatus URL
Categories
(Tree Management :: Treeherder, defect)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
(Blocks 1 open bug)
Details
(Keywords: perf)
(In reply to Ed Morley [:edmorley] from bug 1090301 comment #7)
> In:
> https://github.com/mozilla/treeherder-ui/blob/master/webapp/app/partials/
> main/thWatchedRepoInfoDropDown.html
>
> We have:
> <a href="https://treestatus.mozilla.org/{{treeStatus}}"
> target="_blank">tree status</a>
>
> and:
> <a href="https://secure.pub.build.mozilla.org/clobberer/?branch={{::name}}"
> target="_blank">clobberer</a>
>
> Is there a reason why the latter can use one-time binding and not the former?
(In reply to Cameron Dawson [:camd] from comment #8)
> Yeah, that one should be fine with one-way binding, too. I just missed it.
> Good catch! You up for fixing that?
Comment 1•10 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder-ui
https://github.com/mozilla/treeherder-ui/commit/fd0fb7d2cecbe285d05566c18f5047a473181ed5
Bug 1099146 - Use Angular one-time binding for the treestatus URL
Assignee | ||
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 2•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/f094bb47155149f06dac4d323d9afbcf3ca348d7
Bug 1099146 - Use Angular one-time binding for the treestatus URL
You need to log in
before you can comment on or make changes to this bug.
Description
•