Closed
Bug 1100777
Opened 10 years ago
Closed 10 years ago
Create LayoutPageView component
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(b2g-v2.2 fixed)
RESOLVED
FIXED
2.1 S9 (21Nov)
| Tracking | Status | |
|---|---|---|
| b2g-v2.2 | --- | fixed |
People
(Reporter: rudyl, Assigned: rudyl)
References
Details
(Whiteboard: [p=2])
Attachments
(1 file)
As we have KeyView with bug 1095355 for general key rendering, now we should create a LayoutPageView component, which would aggregate the KeyViews.
|
Assignee | |
Updated•10 years ago
|
Summary: Create KeyView component → Create LayoutPageView component
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → rlu
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8525219 [details]
Patch V1
As discussed in the morning, I'll try to separate the DOM related code out of render.js as ViewClass.
Some issues are not addressed yet, like resizeUI() and candidate panels part, which would be handled in follow-ups.
Tim, could you please help review this?
Thank you.
Attachment #8525219 -
Attachment description: WIP → Patch V1
Attachment #8525219 -
Flags: review?(timdream)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8525219 [details]
Patch V1
Look great! Please set review again after nits are addressed.
Attachment #8525219 -
Flags: review?(timdream) → feedback+
|
|
Assignee | |
Comment 4•10 years ago
|
||
Comment on attachment 8525219 [details]
Patch V1
Patch updated to address the comments, thanks.
I did not remove activeIme variable as stated below,
==
There are still several parts, like resizeUI and candidatePanel related code that would depend on activeIme, and even worse, the unit tests would also reference that.
So I would like to postpone this refactoring to the next bug, if you think this is OK.
Attachment #8525219 -
Flags: review?(timdream)
|
|
||
Comment 5•10 years ago
|
||
Comment on attachment 8525219 [details]
Patch V1
Do ping me if you are unsure if the changes need another review. Thanks.
Attachment #8525219 -
Flags: review?(timdream) → review+
|
|
Assignee | |
Comment 6•10 years ago
|
||
Patch updated again, Tim, could you please take a look again?
Thanks.
The last commit is,
https://github.com/RudyLu/gaia/commit/1fbce2ee43b51d4fa79bfa3b4b657540c46c55e0
Flags: needinfo?(timdream)
|
|
Assignee | |
Comment 8•10 years ago
|
||
master,
https://github.com/mozilla-b2g/gaia/commit/9665cca8bd3e97b43a25232d0245672059d674e0
--
The CI has passed after retriggering Gip - f2.
Thanks for the review.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-b2g-v2.2:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [p=2]
Target Milestone: --- → 2.1 S9 (21Nov)
You need to log in
before you can comment on or make changes to this bug.
Description
•