Closed
Bug 1105178
Opened 10 years ago
Closed 10 years ago
Separate resize out to LayoutPageView
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(b2g-v2.2 fixed)
RESOLVED
FIXED
2.2 S2 (19dec)
| Tracking | Status | |
|---|---|---|
| b2g-v2.2 | --- | fixed |
People
(Reporter: rudyl, Assigned: rudyl)
References
Details
Attachments
(1 file, 1 obsolete file)
We should let LayoutPageView component handle the resize related DOM operation, and eventually maybe we can remove this when bug 1099488 is implemented.
|
Assignee | |
Comment 1•10 years ago
|
||
Hi Tim,
This is just a WIP, but set feedback? to get early feedback/advice.
ToDo:
1. Let writingPadView handle its own resizing.
2. Tests.
Thanks.
Attachment #8528904 -
Flags: feedback?(timdream)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8528904 [details]
WIP
Will talk to you offline on this.
Attachment #8528904 -
Flags: feedback?(timdream)
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → rlu
|
|
Assignee | |
Comment 3•10 years ago
|
||
This is the second attempt to address this issue, this time with flex box.
If possible, please give early feedback while I am going to work on the test part.
Thanks.
Attachment #8536521 -
Flags: feedback?(timdream)
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8528904 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•10 years ago
|
Status: NEW → ASSIGNED
|
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8536521 [details]
Patch V1
1. The comment of resizeUI() needs update.
2. Please further reduce the math and redundant class name.
We can do review on the next round.
Attachment #8536521 -
Flags: feedback?(timdream) → feedback+
|
|
Assignee | |
Comment 5•10 years ago
|
||
Comment on attachment 8536521 [details]
Patch V1
I think this is ready for review.
Tim, could you please help take a look again?
Thanks.
Attachment #8536521 -
Flags: review?(timdream)
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8536521 -
Attachment description: WIP 2 → Patch V1
|
|
||
Updated•10 years ago
|
Attachment #8536521 -
Flags: review?(timdream) → review+
|
|
Assignee | |
Comment 6•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-b2g-v2.2:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S2 (19dec)
You need to log in
before you can comment on or make changes to this bug.
Description
•