Issues I noticed after bug 1085771 lands: * The plus button in the tab strip is light and clashes with light themes * The grey text on the unselected tabs clashes with just about everything * (?) Back/forward button state when pressed/focused/etc. might look terrible * Pressed tab color in tab strip looks too dark on light themes

Mike, do you think this is v1 material?

As long as I can get bug 1085771 to land soon, then yes, I think this is v1 material - it'll look pretty amateur if we don't get at least a dark/light swap working.

I wonder if we shouldn't also change the icon colors (about:home favicon, close button, dividers) to a lighter color - maybe after bug 1105546. Note that we do mischaracterize (imo) some light themes as dark and vice versa, which makes this backfire sometimes.

Anthony, let me know if you have any objections to the screenshots in this bug.

The added assets are trimaged. To create the new assets, I ran: convert tab_new.png -background #5F6368 -alpha shape <out-file> where #5F6368 comes from the color I found for drawable-xhdpi/close.png.

Comment on attachment 8535323 [details] [diff] [review] Part 3: Change add tab button to a dark color on light themes on new tablet Review of attachment 8535323 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me

Comment on attachment 8535218 [details] [diff] [review] Part 2: Add alpha to pressed state of tabs with LWT on new tablet Review of attachment 8535218 [details] [diff] [review]: ----------------------------------------------------------------- All good.

(In reply to Michael Comella (:mcomella) from comment #10) > Anthony, let me know if you have any objections to the screenshots in this > bug. Looks good to me. What opacity value are we using BTW? Just so we could reuse some of those numbers later if we need.

(In reply to Anthony Lam (:antlam) from comment #14) > Looks good to me. What opacity value are we using BTW? Just so we could > reuse some of those numbers later if we need. For the pressed tabs, 170 / 255.

https://hg.mozilla.org/integration/fx-team/rev/f57690535a49 https://hg.mozilla.org/integration/fx-team/rev/6ecba299e659 https://hg.mozilla.org/integration/fx-team/rev/96e778e6b268

Comment on attachment 8535197 [details] [diff] [review] Part 1: Use a light text color for tab titles with a dark LWT on new tablet This request applies to parts 1-3, uplift dependency on bug 1085771. Approval Request Comment [Feature/regressing bug #]: New tablet release [User impact if declined]: New tablet UI will look unpolished w/ lightweight themes enabled. [Describe test coverage new/current, TBPL]: None [Risks and why]: We only touch lightweight theme code so somewhere along the line we could mess up the way lightweight themes work. [String/UUID change made/needed]: None

https://hg.mozilla.org/mozilla-central/rev/f57690535a49 https://hg.mozilla.org/mozilla-central/rev/6ecba299e659 https://hg.mozilla.org/mozilla-central/rev/96e778e6b268

https://hg.mozilla.org/releases/mozilla-aurora/rev/52dfbfd086d0 https://hg.mozilla.org/releases/mozilla-aurora/rev/cd9788ebebcc https://hg.mozilla.org/releases/mozilla-aurora/rev/64c6aa56aa22

Verified as fixed in Firefox for Android 37.0a1 (2014-12-18) Firefox for Android 36.0a2 (2014-12-18) Device: Asus Transformer Pad TF300T (Android 4.2.1)

I can still see the behavior described in Bug 1110157, but only if you tap on the already selected tab; is this intended?

(In reply to Mihai Pop from comment #21) > I can still see the behavior described in Bug 1110157, but only if you tap > on the already selected tab; is this intended? While I'm not sure I directly consulted :antlam on this one, yes, it is intended.