Closed
Bug 1106707
Opened 10 years ago
Closed 10 years ago
Add in support for win32/win64 builds
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: sfink, Assigned: sfink)
References
Details
Attachments
(4 files, 1 obsolete file)
(deleted),
patch
|
bhearsum
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
bhearsum
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
bhearsum
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
coop
:
review+
|
Details | Diff | Splinter Review |
I am slowly getting closer to enabling spidermonkey builds on win32 and win64. There are some necessary bits distributed among the mozharness scripts and config and the buildbot config that I need here.
The main build script for spidermonkey has now moved in-tree. spidermonkey.sh is now just an adapter script to allow the in-tree autospider.sh to be invoked from buildbot. (Well, it also still contains the logic to do the full build, for older branches.)
Assignee | ||
Comment 1•10 years ago
|
||
--platform allows specifying win32 vs win64
The Windows builders require mozmake, but are currently running MozillaBuild 1.5.1 (!) which does not contain it, so we need to fetch it from tooltool.
Attachment #8531119 -
Flags: review?(bhearsum)
Comment 2•10 years ago
|
||
Comment on attachment 8531119 [details] [diff] [review]
Add in support for win32/win64 builds
Review of attachment 8531119 [details] [diff] [review]:
-----------------------------------------------------------------
::: scripts/spidermonkey_builds/spidermonkey.sh
@@ +12,1 @@
>
This is something that's defined in the production/staging configs, so it should probably be passed through from there if possible. (Eg: https://github.com/mozilla/build-buildbot-configs/blob/master/mozilla/production_config.py#L88). Everything else seems fine.
Attachment #8531119 -
Flags: review?(bhearsum) → feedback+
Assignee | ||
Comment 3•10 years ago
|
||
I'll pass it through a command line option.
Attachment #8540971 -
Flags: review?(bhearsum)
Assignee | ||
Updated•10 years ago
|
Attachment #8531119 -
Attachment is obsolete: true
Assignee | ||
Comment 4•10 years ago
|
||
Give the tooltool server and the platform (so spidermonkey.sh/autospider.sh can distinguish between win32 and win64 builds.)
Attachment #8540972 -
Flags: review?(bhearsum)
Updated•10 years ago
|
Attachment #8540972 -
Flags: review?(bhearsum) → review+
Updated•10 years ago
|
Attachment #8540971 -
Flags: review?(bhearsum) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Comment 6•10 years ago
|
||
In production: https://hg.mozilla.org/build/buildbotcustom/rev/ef812b5bdee9
Assignee | ||
Comment 7•10 years ago
|
||
This didn't completely work. I think I'm pulling the tooltool_url_list from the wrong config. Trying out a fix now.
Assignee | ||
Comment 8•10 years ago
|
||
According to my diff, this should do the trick.
Attachment #8552044 -
Flags: review?(bhearsum)
Updated•10 years ago
|
Attachment #8552044 -
Flags: review?(bhearsum) → review+
Assignee | ||
Comment 9•10 years ago
|
||
Comment 10•10 years ago
|
||
In production: https://hg.mozilla.org/build/buildbotcustom/rev/f74d08aada8d
Comment 11•10 years ago
|
||
(In reply to Chris Cooper [:coop] from comment #10)
> In production: https://hg.mozilla.org/build/buildbotcustom/rev/f74d08aada8d
I think this may have caused some spidermonkey-specific bustage, as reported by philor:
https://treeherder.mozilla.org/logviewer.html#?job_id=5771113&repo=mozilla-inbound
Assignee | ||
Comment 12•10 years ago
|
||
Argh! Put the arguments out of order. Fix the build script to allow any order.
Assignee | ||
Updated•10 years ago
|
Attachment #8553143 -
Flags: review?(bhearsum)
Updated•10 years ago
|
Attachment #8553143 -
Flags: review?(bhearsum) → review+
Assignee | ||
Comment 13•10 years ago
|
||
Assignee | ||
Comment 14•10 years ago
|
||
This is working, finally.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 15•10 years ago
|
||
\o/
Updated•6 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•