Closed
Bug 1108834
Opened 10 years ago
Closed 10 years ago
Add visitSubstr method to none backend
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: stevensn, Assigned: stevensn)
References
Details
Attachments
(2 files, 1 obsolete file)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
h4writer
:
review+
|
Details | Diff | Splinter Review |
The visitSubstr method is missing from the Lowering-none(disable-ion) backend.
Add in a stub method for it.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8533405 -
Flags: review?(hv1989)
Comment 2•10 years ago
|
||
Comment on attachment 8533405 [details] [diff] [review]
visitSubstr.diff
Review of attachment 8533405 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks
Attachment #8533405 -
Flags: review?(hv1989) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Keywords: checkin-needed
Comment 4•10 years ago
|
||
Hi Steve, this patch failed to apply:
renamed 1108834 -> visitSubstr.diff
applying visitSubstr.diff
patching file js/src/jit/none/Lowering-none.h
Hunk #1 FAILED at 83
1 out of 1 hunks FAILED -- saving rejects to file js/src/jit/none/Lowering-none.h.rej
could you take a look, thanks!
Assignee | ||
Comment 5•10 years ago
|
||
Patch was bit-rotten by Bug 1107774
Patch refreshed
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=8d2e958bf79c
Attachment #8533405 -
Attachment is obsolete: true
Flags: needinfo?(steve)
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 6•10 years ago
|
||
Keywords: checkin-needed
Assignee | ||
Comment 7•10 years ago
|
||
Grr, I didn't fix the bit-rot from bug 1107774 properly the return type needs to change.
Is it easier to have this backed out of inbound or to just do another patch that fixes the return type?
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Assignee | ||
Comment 9•10 years ago
|
||
Reopening since the patch just switched one compile error for another
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 10•10 years ago
|
||
This patch fixes the return type
Assignee | ||
Comment 11•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8535351 -
Flags: review?(hv1989)
Updated•10 years ago
|
Attachment #8535351 -
Flags: review?(hv1989) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 12•10 years ago
|
||
Keywords: checkin-needed
Comment 13•10 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•