Closed
Bug 1110115
Opened 10 years ago
Closed 10 years ago
mozharness apk description script: Manage different channels
Categories
(Marketing :: Copy, task)
Marketing
Copy
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
Details
Attachments
(2 files)
(deleted),
patch
|
bhearsum
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
bhearsum
:
review+
|
Details | Diff | Splinter Review |
For now, we are only managing the release channel.
In the future, we would like to manage also beta (and maybe aurora at some points)
However, for now, this is not yet available even if Pascal documented this future API:
https://l10n.mozilla-community.org/~pascalc/google_play_description/api/
Comment 1•10 years ago
|
||
The list of locales per channel is now available via the API:
https://l10n.mozilla-community.org/~pascalc/google_play_description/api/?firefox_locales&channel=org.mozilla.fennec_aurora
https://l10n.mozilla-community.org/~pascalc/google_play_description/api/?firefox_locales&channel=org.mozilla.firefox_beta
https://l10n.mozilla-community.org/~pascalc/google_play_description/api/?firefox_locales&channel=org.mozilla.firefox
Not though that the lists are identical now since we have the same set of locales in the 3 channels:
http://hg.mozilla.org/releases/mozilla-release/raw-file/tip/mobile/android/locales/maemo-locales
http://hg.mozilla.org/releases/mozilla-beta/raw-file/tip/mobile/android/locales/maemo-locales
http://hg.mozilla.org/releases/mozilla-aurora/raw-file/tip/mobile/android/locales/maemo-locales
(if I am not looking at the right files in hg for the list of locales we ship per channel, please tell me).
Implementing the API to expose the actual translations and the status of the work done for the aurora and beta channels would mean that we actually translate the google play description for these channels but we didn't get requests to get that localized yet.
I can make API calls to aurora and beta channels return empty lists of locales done until we actually get the content to localize.
l10n-drivers don't own the actual English source for the Google Play decription for the various channels, who owns that and would work with us? Arcadio?
Assignee | ||
Comment 2•10 years ago
|
||
The patch is doing a bit more than managing the different channels.
* update some old urls
* use .format instead of concat of string (we have several args in the url now)
* introduce a new method get_translation (to simplify testing and the code)
* remove some hardcoded string to use the one provided by Pascal's interface
Attachment #8544692 -
Flags: review?(bhearsum)
Assignee | ||
Comment 3•10 years ago
|
||
I improved & updated the test suite with the recent changes.
Attachment #8544694 -
Flags: review?(bhearsum)
Updated•10 years ago
|
Attachment #8544692 -
Flags: review?(bhearsum) → review+
Updated•10 years ago
|
Attachment #8544694 -
Flags: review?(bhearsum) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Thanks, merged!
http://hg.mozilla.org/build/mozharness/rev/3e1c630025bb
http://hg.mozilla.org/build/mozharness/rev/d8d4c5aad8f8
On my side, this bug is fixed. Pascal, don't hesitate to reopen if you disagree!
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 5•10 years ago
|
||
In production: https://hg.mozilla.org/build/mozharness/rev/3e1c630025bb
Comment 6•10 years ago
|
||
In production: https://hg.mozilla.org/build/mozharness/rev/d8d4c5aad8f8
You need to log in
before you can comment on or make changes to this bug.
Description
•