Andrew Halberstadt [:ahal] Reporter
	Description • 10 years ago

Once mozharness test scripts have been set up to support code coverage in bug 1059951, we'll need to enable it by passing in --code-coverage in buildbot-configs.

	Andrew Halberstadt [:ahal] Reporter
	Comment 1 • 9 years ago

/r/7859 - Bug 1110465 - Append --code-coverage to unittests on linux64-cc builds

Pull down this commit:

hg pull -r b8185431beec8c4c792850cb6db7f39741b4b55c https://reviewboard-hg.mozilla.org/buildbot-configs

	Andrew Halberstadt [:ahal] Reporter
	Comment 2 • 9 years ago

This passes all the tests when running `tox`, but I'm not 100% sure it does what I want. Just to be clear, I want to pass in --code-coverage into every test job that runs on a linux64-cc build, regardless of mozharness script used.

Linux64-cc is currently only scheduled on try as a non-default platform.

	Chris AtLee [:catlee]
	Comment 3 • 9 years ago

Comment on attachment 8599344 [details]
MozReview Request: bz://1110465/ahal

https://reviewboard.mozilla.org/r/7857/#review6927

::: mozilla-tests/config.py:1036
(Diff revision 1)
> +                },

is this an intentional addition?

	Andrew Halberstadt [:ahal] Reporter
	Comment 4 • 9 years ago

https://reviewboard.mozilla.org/r/7857/#review6931

> is this an intentional addition?

Yeah, should have clarified that. I noticed that e10s bc jobs were failing on linux64-cc in https://treeherder.mozilla.org/#/jobs?repo=try&revision=4b39871a9eba due to not having a config file set. Looks like whoever added mochitest-e10s-browser-chrome forgot to add that config to linux64-cc. I didn't want to make a separate patch for it, but I can if that's what you prefer.

	Chris AtLee [:catlee]
	Comment 5 • 9 years ago

Comment on attachment 8599344 [details]
MozReview Request: bz://1110465/ahal

https://reviewboard.mozilla.org/r/7857/#review6937

Ship It!

	Chris AtLee [:catlee]
	Comment 6 • 9 years ago

https://reviewboard.mozilla.org/r/7857/#review6935

> Yeah, should have clarified that. I noticed that e10s bc jobs were failing on linux64-cc in https://treeherder.mozilla.org/#/jobs?repo=try&revision=4b39871a9eba due to not having a config file set. Looks like whoever added mochitest-e10s-browser-chrome forgot to add that config to linux64-cc. I didn't want to make a separate patch for it, but I can if that's what you prefer.

np, just curious

	Andrew Halberstadt [:ahal] Reporter
	Comment 7 • 9 years ago

Comment on attachment 8599344 [details]
MozReview Request: bz://1110465/ahal

https://hg.mozilla.org/build/buildbot-configs/rev/d95c0c0e9d22

	Rail Aliiev [:rail]
	Comment 8 • 9 years ago

In production: https://hg.mozilla.org/build/buildbot-configs/rev/d95c0c0e9d22

	Andrew Halberstadt [:ahal] Reporter
	Comment 9 • 9 years ago

Hm, either this didn't do what I expected, or my try push didn't pick up a late enough buildbot-configs revision:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a6fa120632d8

--code-coverage did not get passed into the desktop_unittests.py mozharness script.

	Andrew Halberstadt [:ahal] Reporter
	Comment 10 • 9 years ago

I thought adding 'extra_args' to the platform config would work because of this:
https://mxr.mozilla.org/build/source/buildbotcustom/misc.py#715

But perhaps 'extra_args' is being set in the suite config or something so that if statement evaluates to False? Could we change it so we start out with the platform 'extra_args' if it exists, and then update it with the suite 'extra_args'? I need some help, I'm not even sure if misc.py is the place I should be looking.

It would be possible to make a new set of "code coverage" suite objects in the config, but they would be identical to the original (except for 'extra_args') and would double the size of the suite configs. It would be much cleaner if I could find a way to use platform 'extra_args'.

	Rail Aliiev [:rail]
	Comment 11 • 9 years ago

Sorry it took so long. :(

It's a but confusing, but I think this is where it should be set:
http://hg.mozilla.org/build/buildbot-configs/file/412dd262495e/mozilla/config.py#l731

because http://hg.mozilla.org/build/buildbotcustom/file/f485b72ea71f/misc.py#l979 :/

	Andrew Halberstadt [:ahal] Reporter
	Comment 12 • 9 years ago

That looks like it goes into the build script though.. I need this to go into every test job that runs on a particular builder.

	Andrew Halberstadt [:ahal] Reporter
	Comment 13 • 9 years ago

I'm going to solve this a slightly hackier, but much more straightforward way in mozharness by comparing the buildername to a list of known platforms code coverage should be enabled on.