Closed
Bug 1110552
Opened 10 years ago
Closed 10 years ago
improve performance of filtering jobs, platforms and groups
Categories
(Tree Management :: Treeherder, defect, P1)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: camd, Assigned: camd)
References
(Blocks 1 open bug)
Details
(Keywords: perf)
Attachments
(1 file)
The hiding/showing and general render time of jobs, platforms and groups could be improved.
Assignee | ||
Comment 1•10 years ago
|
||
This improves switching filters on and off and general job render speed by about 30% according to this set of tests:
http://jsperf.com/treeherder-showhide2
However, it's not quite there yet. Some reliability issues still.
Comment 2•10 years ago
|
||
(In reply to Cameron Dawson [:camd] from comment #1)
> This improves switching filters on and off and general job render speed by
> about 30% according to this set of tests:
Nice work! :-)
Assignee: nobody → cdawson
Status: NEW → ASSIGNED
Priority: -- → P1
Assignee | ||
Comment 3•10 years ago
|
||
Well, that other attempt didn't pan out as well as I'd hoped. These changes are more like 17% better than 30%. Adding or removing the ``filter-shown`` class was faster using the DOM rather than jQuery. But then the jquery selectors couldn't find it reliably, so it just didn't function properly.
This is the best I have so far. If we could find a way to do it without adding/removing the class from the job, that may be faster still. But all my attempts ended up being slower. :/
Assignee | ||
Comment 4•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8542741 -
Flags: review?(mdoglio)
Updated•10 years ago
|
Attachment #8542741 -
Flags: review?(mdoglio) → review+
Comment 5•10 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder-ui
https://github.com/mozilla/treeherder-ui/commit/f24ab8fb9be5cd1854364246d6f4a15ec21c5fb2
Bug 1110552 - faster ``showHideJob`` perf
Switched from using jQuery for showing/hiding and finding
classes to using DOM calls. This ended up being about 17% faster when
toggling unclassified failures. Also made ``filter-shown`` class maintain
the visible/not visible attributes, rather than setting them explicitly.
Assignee | ||
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 6•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/c50159c07be325c19c954964ab70c4abea76c0ec
Bug 1110552 - faster ``showHideJob`` perf
Switched from using jQuery for showing/hiding and finding
classes to using DOM calls. This ended up being about 17% faster when
toggling unclassified failures. Also made ``filter-shown`` class maintain
the visible/not visible attributes, rather than setting them explicitly.
You need to log in
before you can comment on or make changes to this bug.
Description
•