Closed Bug 1110652 Opened 10 years ago Closed 10 years ago

[Stingray] use interactive notification to show desktop-notification

Categories

(Firefox OS Graveyard :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: johnhu, Assigned: johnhu)

References

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 file)

create interactive notification and use it to show desktop-notification.

Because we don't have visual spec, it is fine to show the notification to console.
Rex,

Please review this patch. Thanks. I will use another issue to create the UI of interactive notification. BTW, please also test the test case. You may need to change rename the folder _test to test to have it.
Attachment #8535508 - Flags: review?(rexboy)
Blocks: 1111416
No longer blocks: 1111416
Blocks: 1111417
Blocks: 1111414
Comment on attachment 8535508 [details]
create and use interactive notification

r+ but this patch leaves follow-up works that need to be done:
- UI part of the Interactive notification
- More detailed test for replacing original toast notification to current internative notification. (Especially for buttons, which is difficult to test before UI part is finished)

Before check-in please see Github comments. Thanks for the work!
Attachment #8535508 - Flags: review?(rexboy) → review+
Blocks: 1114397
Blocks: 1114399
No longer blocks: 1114399
merged to master:
https://github.com/mozilla-b2g/gaia/commit/8235ab2d1b94b565601b9674f672ef4563577b50

gaia-try is all green with one intermittent error
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=de3d1b58a74b
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: