Closed
Bug 1112210
Opened 10 years ago
Closed 10 years ago
remotetroubleshooting data of {} is being saved
Categories
(Input Graveyard :: Submission, defect, P1)
Input Graveyard
Submission
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: willkg, Assigned: willkg)
References
Details
(Whiteboard: u=user c=feedback p=1 s=input.2014q4)
I checked this morning and noticed a bunch of RemoteTroubleshootingInfo records with a data value of {}.
We shouldn't be saving empty data to the db.
This bug covers fixing that and either writing a test for it or figuring out why the existing test isn't working.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → willkg
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•10 years ago
|
||
Oops--that should be ResponseTroubleshootingInfo records.
Assignee | ||
Comment 2•10 years ago
|
||
Assignee | ||
Comment 3•10 years ago
|
||
Assignee | ||
Comment 4•10 years ago
|
||
Pushed to prod just now.
Need to wait until I see an optin ping before I close this as FIXED.
Assignee | ||
Comment 5•10 years ago
|
||
Added a "yes--we have browser data" indicator to response view. In a PR: https://github.com/mozilla/fjord/pull/419
Assignee | ||
Comment 6•10 years ago
|
||
Landed in master: https://github.com/mozilla/fjord/commit/278095d5d5684c9d78e7c93f14fa15ecd4a7bfd3
Verified it works and that my test feedback earlier did have browser data. My dashboard needs fixing. :(
Marking as FIXED.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•10 years ago
|
Blocks: 1104932
Whiteboard: u=user c=feedback p= s=input.2014q4 → u=user c=feedback p=1 s=input.2014q4
Updated•8 years ago
|
Product: Input → Input Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•