Mark Banner (:standard8) Assignee
	Description • 10 years ago

Once bug 1103331 is fixed and deployed on the server side, we might want to show the name of the room before the user enters it.

	Mark Banner (:standard8) Assignee
	Comment 1 • 9 years ago

Needed for the context in conversations work.

	Mark Banner (:standard8) Assignee
	Comment 2 • 9 years ago

Simple patch to move the existing get call earlier in the flow - only needed for standalone, desktop manages elsewhere.

	Mike de Boer [:mikedeboer]
	Comment 3 • 9 years ago

Comment on attachment 8582487 [details] [diff] [review]
Show the room name before the user enters the room.

Review of attachment 8582487 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

::: browser/components/loop/content/shared/js/activeRoomStore.js
@@ +181,5 @@
>          }.bind(this));
>      },
>  
>      /**
> +     * Execute fetchServerData event action from the dispatcher. For rooms

I think it's be good to keep mentioning that this method is used by the standalone client only.

@@ +215,5 @@
> +            return;
> +          }
> +
> +          this.dispatcher.dispatch(new sharedActions.UpdateRoomInfo(result));
> +      }.bind(this));

nit: please align this brace with the opening one (indentation)

	Mark Banner (:standard8) Assignee
	Comment 4 • 9 years ago

https://hg.mozilla.org/integration/fx-team/rev/c5bce379c537

	Ryan VanderMeulen [:RyanVM]
	Comment 5 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/c5bce379c537