Closed
Bug 1142588
Opened 9 years ago
Closed 9 years ago
Implement context in conversations display for standalone UI
Categories
(Hello (Loop) :: Client, enhancement, P1)
Hello (Loop)
Client
Tracking
(firefox40 verified)
| Tracking | Status | |
|---|---|---|
| firefox40 | --- | verified |
People
(Reporter: standard8, Assigned: standard8)
References
()
Details
(Whiteboard: [context])
User Story
As a link clicker in a conversation, I want to see any contextual information associated with the conversation so that I am better prepared and more engaged when I join. UX: https://bug1115340.bugzilla.mozilla.org/attachment.cgi?id=8568131 Acceptance criteria: * When in a conversation or out of a conversation, the following details about the attached URL get displayed to the link clicker on the right hand side of the screen: - Thumbnail and favicon of the webpage the URL points to - Content of the <title> tag of the webpage the URL points to - URL * Clicking the URL opens the URL in a new tab * Accessing the URL from the standalone client will trigger a Telemetry event
Attachments
(1 file)
|
(deleted),
patch
|
mikedeboer
:
review+
|
Details | Diff | Splinter Review |
Implementation bug for context in conversations on the standalone UI
|
||
Updated•9 years ago
|
Rank: 23
|
|
||
Updated•9 years ago
|
Rank: 23 → 7
Flags: qe-verify+
Flags: firefox-backlog+
Priority: P2 → P1
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → standard8
Iteration: --- → 40.1 - 13 Apr
Points: --- → 3
|
|
Assignee | |
Updated•9 years ago
|
Iteration: 40.1 - 13 Apr → 40.2 - 27 Apr
|
|
Assignee | |
Comment 2•9 years ago
|
||
This adds context display to the standalone UI. Most of this is quite simple. I've done my best on the layout to avoid overlapping the remote/local video. For narrow widths, aka mobile, we just hide the context for now - I've filed bug 1153827 to look into that. The overlapping might also be helped by bug 1153800 or another bug which may end up swapping us to favicons.
Attachment #8591678 -
Flags: review?(mdeboer)
|
||
Comment 3•9 years ago
|
||
I see you're trying to do proportional layout for the context information, but since that's all about text, what are you doing with text overflow when the height is 15% or 20%?
Status: NEW → ASSIGNED
Flags: needinfo?(standard8)
|
|
Assignee | |
Comment 4•9 years ago
|
||
(In reply to Mike de Boer [:mikedeboer] from comment #3) > I see you're trying to do proportional layout for the context information, > but since that's all about text, what are you doing with text overflow when > the height is 15% or 20%? At the moment we just let it overflow. When we get towards the chat UX (see the last couple of pages of https://docs.google.com/a/mozilla.com/document/d/1HwYbM4Eru3rHVT3MStO8eeTunJ7pN5PYBingtmwe-bA/edit?usp=sharing), then I think we can make it scrollable in a sensible manner.
Flags: needinfo?(standard8)
|
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8591678 [details] [diff] [review] Implement context in conversations display for Loop's standalone UI. Review of attachment 8591678 [details] [diff] [review]: ----------------------------------------------------------------- Ship it! ::: browser/components/loop/test/standalone/standaloneRoomViews_test.js @@ +88,5 @@ > + }] > + }); > + > + expect(view.getDOMNode().querySelector(".standalone-context-url")).not.eql(null); > + nit: superfluous newline.
Attachment #8591678 -
Flags: review?(mdeboer) → review+
|
|
Assignee | |
Comment 6•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/7b002a2e4932
Target Milestone: --- → mozilla40
|
||
Updated•9 years ago
|
QA Contact: bogdan.maris
|
||
Comment 8•9 years ago
|
||
Standalone UI contains the context as described in user story using latest Aurora, across platforms (Windows 7 64-bit, Ubuntu 14.04 32-bit and Mac OS X 10.9.5). Will mark this bug as verified fixed and dropping qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•