Closed Bug 111515 Opened 23 years ago Closed 14 years ago

No favicon support for <browser> but <tabbrowser> only

Categories

(SeaMonkey :: UI Design, defect)

x86
Windows NT
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED EXPIRED

People

(Reporter: neilpryde92651, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: helpwanted)

You don't get the favicons if you use the <browser> widget.
And you don't get anyone who can fix if you provide no information.

Please read http://www.mozilla.org/quality/bug-writing-guidelines.html for a
summary of what we need in a bug report.

This WorksForMe, Linux 2001112208.
Assignee: asa → hyatt
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: No favicon support for <browser> but <tabbrowser> only?! → No favicon support for <browser> but <tabbrowser> only
Target Milestone: --- → Future
Favicons work, but not 100%, for the <tabbrowser> widget, but not for the
<browser> widget, what more can I say about this?

You seem to have a working testcase, where can we find that testcase?
What if we add these missing methods to browser.xml? 
+ <method name="buildFavIconString">
+ <method name="shouldLoadFavIcon">
+ <method name="loadFavIcon">
+ <method name="addToMissedIconCache">
+ <method name="onLinkAdded">

And what is we change method onLinkAdded a bit to support browser instead of
tabbrower?
And what if we add this snap:

// Hook up a listener for <link>s.
this.mPanelContainer.addEventListener("DOMLinkAdded", this.onLinkAdded, false);

to <method name="addProgressListener"> to trigger the events fir the favicons?
Blocks: 120352
Status: NEW → ASSIGNED
Component: Browser-General → XP Apps: GUI Features
Keywords: mozilla1.0
QA Contact: doronr → sairuh
QA Contact: sairuh → claudius
Then I say it's time to build a <navigator> (or <mozbrowser>) layer on top of
<browser>. <browser> is supposed to be a browsing object which is also used by
mail/news and view-source, neither of which should be burdened with this
navigator specific code.

-> future, helpwanted.
Keywords: helpwanted
Product: Core → Mozilla Application Suite
Assignee: hyatt → nobody
Status: ASSIGNED → NEW
QA Contact: claudius → guifeatures
Target Milestone: Future → ---
Component: XP Apps: GUI Features → UI Design
MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614
Status: NEW → UNCONFIRMED
MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but still has no comment since the inception of the SeaMonkey project 5 years ago.

Because of this, we're resolving the bug as EXPIRED.

If you still can reproduce the bug on SeaMonkey 2 or otherwise think it's still valid, please REOPEN it and if it is a platform or toolkit issue, move it to the according component.

Query tag for this change: EXPIRED-20100420
Status: UNCONFIRMED → RESOLVED
Closed: 14 years ago
Resolution: --- → EXPIRED
You need to log in before you can comment on or make changes to this bug.