Comment on attachment 8544779 [details] [diff] [review] Mark virtual overridden functions as MOZ_OVERRIDE in parser Review of attachment 8544779 [details] [diff] [review]: ----------------------------------------------------------------- r+ with the comments addressed. ::: parser/html/nsHtml5Parser.cpp @@ +166,5 @@ > { > return mExecutor->IsComplete(); > } > > +nsresult This change doesn't look right to me. It doesn't match the .h file, AFAICT. ::: parser/html/nsHtml5Parser.h @@ +184,5 @@ > > /** > * True in fragment mode and during synchronous document.write > */ > + bool CanInterrupt(); It seems that this method has become dead code, so let's just remove it. ::: parser/html/nsHtml5TreeOpExecutor.h @@ +158,3 @@ > > // XXX Does anyone need this? > nsIDocShell* GetDocShell() It would make sense to remove this method while at it. It looks a lot like the reason this method is still here is that it wasn't flagged as an override in the past and, therefore, has failed to get removed when other classes have changed.